Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown: links not colored when indented #8264

Closed
bpasero opened this issue Jun 28, 2016 · 6 comments · Fixed by #12403
Closed

Markdown: links not colored when indented #8264

bpasero opened this issue Jun 28, 2016 · 6 comments · Fixed by #12403
Assignees
@mjbvz
Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Milestone
November 2016

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Refs: #7945

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Jun 28, 2016
@mjbvz mjbvz assigned mjbvz and unassigned kieferrm Sep 21, 2016
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 21, 2016
@mjbvz
Fix colorization for markdown indented paragraphs
4a59813 
Issue microsoft#8264

**Bug**
Indented paragraphs are not highlighted in markdown files. Up to three spaces are allowed before the first non space character.

**Fix**
Add rule to consume optional spaces before paragrpah start.

closes microsoft#8264
@mjbvz mjbvz mentioned this issue Sep 21, 2016
Merged
kieferrm pushed a commit that referenced this issue Sep 26, 2016
@mjbvz @kieferrm
Fix colorization for markdown indented paragraphs
93d16ef 
Issue #8264

**Bug**
Indented paragraphs are not highlighted in markdown files. Up to three spaces are allowed before the first non space character.

**Fix**
Add rule to consume optional spaces before paragrpah start.

closes #8264
@mjbvz mjbvz added this to the September 2016 milestone Sep 26, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2016

I am still seeing this with latest:

image

@bpasero bpasero reopened this Sep 28, 2016
@bpasero bpasero added the verification-found Issue verification failed label Sep 28, 2016
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 28, 2016

@bpasero How many spaces is the indent? If it's 4 or more, then the text becomes a code block which will not be highlighted

@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2016

@mjbvz this was one Tab. My original bug report was likely also doing that.

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 28, 2016

@bpasero Take a look at the markdown preview and see how the text is rendered. Our highlighting tries to match what it does.

Content indented using either a four space tab or a literal tab both render as code blocks in my testing:

screen shot 2016-09-28 at 10 39 08 am

@bpasero
Copy link
Member Author

bpasero commented Sep 29, 2016

Ok. Just fyi here is how Atom renders it:

image

@bpasero bpasero modified the milestones: October 2016, September 2016 Sep 30, 2016
@kieferrm kieferrm modified the milestones: November 2016, October 2016 Oct 27, 2016
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Nov 11, 2016
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 11, 2016

As long as there are four spaces in front of the link, this behavior is expected:

- VSCode Version:
- OS Version:

Steps to Reproduce:

    [foo](aaa)

Here's the preview we show:

screen shot 2016-11-11 at 2 51 51 pm

And here's how github renders it:

screen shot 2016-11-11 at 2 51 34 pm

Atom is incorrect in this case.

@mjbvz mjbvz closed this as completed Nov 11, 2016
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@rzhao271 rzhao271 removed the verification-found Issue verification failed label Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Projects
None yet
Milestone
November 2016
Development

Successfully merging a pull request may close this issue.

Fix colorization for markdown indented paragraphs mjbvz/vscode
4 participants
@bpasero @kieferrm @rzhao271 @mjbvz