Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger variables UI should highlight changed variable values #866

Closed
daviwil opened this issue Dec 1, 2015 · 4 comments
Closed

Debugger variables UI should highlight changed variable values #866

daviwil opened this issue Dec 1, 2015 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Dec 1, 2015

In Visual Studio, variables shown in the Locals window are marked with a red foreground color when they change between two debugger stop events:

image

It would be great to also have this functionality in VS Code. Even better if the debug adapter could send some kind of isChanged field back on individual variables when they are requested.

cc @rkeithhill

@egamma egamma added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 1, 2015
@rkeithhill
Copy link

+1 for this feature.

@isidorn isidorn self-assigned this Dec 3, 2015
@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2015

If the adapter could send it to VSCode it would be pretty trivial for me to implement this.
Though I have the model on the vscode side so I could also check for the variable change - might not be so trivial since I get all new variables on each stop event and I am not aware what variables existed in the previous step.

@weinand what do you think? On which side should this logic live? Adapter or VSCode

@weinand
Copy link
Contributor

weinand commented Dec 3, 2015

@isidorn I do not have the old state and I do not want to introduce a new model for preserving the old state. Since the UI has the old state by definition (it's visible in the UI), it makes more sense to implement this feature there. In addition we can offload repeated implementations of this feature from debug-adaptor authors.

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2015

Makes sense. I can look into this over holidays 🎅

@egamma egamma modified the milestone: Backlog Dec 10, 2015
@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@egamma egamma modified the milestones: Jan 2016, Backlog Jan 6, 2016
@egamma egamma mentioned this issue Feb 1, 2016
97 tasks
@isidorn isidorn added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants