debug: show variables changed in red in viewlet.

fixes #866
microsoft · Dec 22, 2015 · aa00bb9 · aa00bb9
1 parent af9bc1f
commit aa00bb9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/src/vs/workbench/parts/debug/browser/debugViewer.ts b/src/vs/workbench/parts/debug/browser/debugViewer.ts
@@ -57,10 +57,14 @@ export function renderExpressionValue(tree: tree.ITree, arg2: debug.IExpression|
 	container.title = value;
 }
 
-export function renderVariable(tree: tree.ITree, variable: model.Variable, data: IVariableTemplateData, debugInactive: boolean): void {
+export function renderVariable(tree: tree.ITree, variable: model.Variable, data: IVariableTemplateData, debugInactive: boolean, showChanged: boolean): void {
 	data.name.textContent = `${variable.name}:`;
 	if (variable.value) {
 		renderExpressionValue(tree, variable, debugInactive, data.value);
+		if (variable.valueChanged && showChanged) {
+			// Value changed color has priority over other colors.
+			data.value.className = 'value changed';
+		}
 	} else {
 		data.value.textContent = '';
 		data.value.title = '';
@@ -435,7 +439,7 @@ export class VariablesRenderer implements tree.IRenderer {
 		if (templateId === VariablesRenderer.SCOPE_TEMPLATE_ID) {
 			this.renderScope(element, templateData);
 		} else {
-			renderVariable(tree, element, templateData, this.debugService.getState() === debug.State.Inactive);
+			renderVariable(tree, element, templateData, this.debugService.getState() === debug.State.Inactive, true);
 		}
 	}
 

diff --git a/src/vs/workbench/parts/debug/browser/media/debugViewlet.css b/src/vs/workbench/parts/debug/browser/media/debugViewlet.css
@@ -122,6 +122,10 @@
 	font-size: 11px;
 }
 
+.debug-viewlet .monaco-tree-row .expression .value.changed {
+	color: #E51400;
+}
+
 .debug-viewlet .monaco-inputbox {
 	width: 100%;
 	line-height: normal;
@@ -152,6 +156,10 @@
 	background: url('add-inverse.svg') center center no-repeat;
 }
 
+.vs-dark .debug-viewlet .monaco-tree-row .expression .value.changed {
+	color: #c10;
+}
+
 /* Breakpoints */
 
 .debug-viewlet .debug-breakpoints .breakpoint {

diff --git a/src/vs/workbench/parts/debug/browser/replViewer.ts b/src/vs/workbench/parts/debug/browser/replViewer.ts
@@ -201,7 +201,7 @@ export class ReplExpressionsRenderer implements tree.IRenderer {
 
 	public renderElement(tree: tree.ITree, element: any, templateId: string, templateData: any): void {
 		if (templateId === ReplExpressionsRenderer.VARIABLE_TEMPLATE_ID) {
-			debugviewer.renderVariable(tree, element, templateData, this.debugService.getState() === debug.State.Inactive);
+			debugviewer.renderVariable(tree, element, templateData, this.debugService.getState() === debug.State.Inactive, false);
 		} else if (templateId === ReplExpressionsRenderer.INPUT_OUTPUT_PAIR_TEMPLATE_ID) {
 			this.renderInputOutputPair(tree, element, templateData);
 		} else if (templateId === ReplExpressionsRenderer.VALUE_OUTPUT_TEMPLATE_ID) {

diff --git a/src/vs/workbench/parts/debug/common/debugModel.ts b/src/vs/workbench/parts/debug/common/debugModel.ts
@@ -186,13 +186,17 @@ export class Expression implements debug.IExpression {
 
 export class Variable implements debug.IExpression {
 
+	public static allValues: { [id: string]: string } = {};
 	// Cache children to optimize debug hover behaviour.
 	private children: TPromise<debug.IExpression[]>;
 	public value: string;
+	public valueChanged: boolean;
 
 	constructor(public parent: debug.IExpressionContainer, public reference: number, public name: string, value: string) {
 		this.children = null;
 		this.value = massageValue(value);
+		this.valueChanged = Variable.allValues[this.getId()] && Variable.allValues[this.getId()] !== value;
+		Variable.allValues[this.getId()] = value;
 	}
 
 	public getId(): string {
@@ -336,6 +340,7 @@ export class Model extends ee.EventEmitter implements debug.IModel {
 		} else {
 			if (removeThreads) {
 				this.threads = {};
+				Variable.allValues = {};
 			} else {
 				for (var ref in this.threads) {
 					if (this.threads.hasOwnProperty(ref)) {