Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font feature settings in terminal #89085

Closed
AlsoScratch opened this issue Jan 22, 2020 · 6 comments
Closed

Font feature settings in terminal #89085

AlsoScratch opened this issue Jan 22, 2020 · 6 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label

Comments

@AlsoScratch
Copy link

  • VSCode Version: 1.41.1
  • OS Version: macOS 10.15.2

Like #87994 but now involves the terminal.
Screenshot 2020-01-22 at 8 43 47 PM
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jan 22, 2020
@Tyriar
Copy link
Member

Tyriar commented Jan 23, 2020

The terminal has a separate set of font settings, it inherits some of the editor's values if they're not set though.

@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jan 23, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 23, 2020

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jan 23, 2020
@AlsoScratch
Copy link
Author

What is the settings.json code for the terminal then?

@AlsoScratch AlsoScratch changed the title Propagate font feature settings to terminal Font feature settings in terminal Jan 23, 2020
@AlsoScratch AlsoScratch mentioned this issue Jan 23, 2020
Closed
@Tyriar
Copy link
Member

Tyriar commented Jan 23, 2020

image

@octref
Copy link
Contributor

octref commented Feb 3, 2020

@Tyriar I think he's asking for editor.fontLigatures to be propagated as well.

@Tyriar
Copy link
Member

Tyriar commented Feb 3, 2020

Ligatures -> #34103

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @octref @AlsoScratch