Propagate font feature settings from editor to suggest widget

[AlsoScratch]

• VSCode Version: 1.41.1
• OS Version: macOS 10.15.2

Steps to Reproduce:

1. Open a file, such as the settings.json document
2. Type something that will make the fill suggestions appear

Does this issue occur when all extensions are disabled?: Yes

The text in the editor is correct based on my OpenType settings, but the fill suggestions are still the default. (Note differences in i and l)

[jrieken]

Are you talking about the font?

[AlsoScratch]

Of course, it is about the font.

[AlsoScratch]

Umm... I don't understand the new title. I just thought that when OpenType customization was implemented for the editor, the fill suggestions were overlooked.

[AlsoScratch]

Notice the i in the editor does not match the i in the fill suggestion list.

[jrieken]

Umm... I don't understand the new title. I just thought that when OpenType customization was implemented for the editor, the fill suggestions were overlooked.

Forgot a word, updates the title again

[AlsoScratch]

[AlsoScratch]

The IntelliSense just needs to automatically match the editor.

[jrieken]

Well, turns out we actually do apply the editor font in the suggest widget. I guess this is a ligature issue. @AlsoScratch Please share your settings with me.

[AlsoScratch]

It's a font called Iosevka and it uses what I may call custom OpenType tags to modify individual characters like g, i, l, y, etc.

[AlsoScratch]

The settings.json file

{
    "editor.fontFamily": "'Iosevka Term', 'IBM Plex Mono', Menlo, Monaco, 'Courier New', monospace",
    "editor.fontLigatures": "'cv01', 'cv05', 'cv11', 'cv19', 'cv21', 'cv23', 'cv26', 'cv27', 'cv36', 'cv38', 'cv45', 'cv46', 'cv49', 'cv51', 'cv52', 'cv65'",
    "editor.lineHeight": 22
}

[jrieken]

Ok, I am starting to understand now (sorry not a font expert). I have pushed a change that makes sure that we use the same font features in the suggest widget as we do in the editor. Tomorrow's insider build should contains this change, please report back if it then works for you.

[AlsoScratch]

I don't use insider, I only trust official releases.

[jrieken]

Insiders is an official release.

[AlsoScratch]

Insiders is an official release.

Isn't it the one that always has the latest commit, something like that?

[jrieken]

It's a daily build (usually from 8am CET) which contains the latest changes and allows you to see what will come in VS Code.

[AlsoScratch]

Oh, I just realized that the word 'settings' in the title is misspelled.

[octref]

@jrieken Your change is applied to the details widget, but I think the OP is asking for the suggest item list to share font feature setting.

I don't think we want to apply the font feature settings to the details widget, as it uses system's default sans-serif font (such as San Francisco on macOS), and font features that apply to monospace coding font (such as his choice, Ioveska) might cause weird rendering in details widget.

In short, I suggest taking 6f428b1 and removing bf2dbfc.

[octref]

@jrieken Lemme know if I can remove bf2dbfc

[AlsoScratch]

It also needs to be propagated to the Python terminal.

[octref]

Please open new issue for terminal then. It is a completely different area.