Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick access: editor picker: Editor group picker doesn't announce group #93935

Closed
Tyriar opened this issue Mar 31, 2020 · 1 comment
Closed

Quick access: editor picker: Editor group picker doesn't announce group #93935

Tyriar opened this issue Mar 31, 2020 · 1 comment
Assignees
@bpasero
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020 •
edited
Loading

#93637

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

In this state with NVDA:

image

It announces: "Quick access dot ts, editor group picker 4 of 5", no mention of which group it is.
@bpasero bpasero added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues quick-pick Quick-pick widget issues labels Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Since the edt quick pick is about navigation and focus I think reading the group in general makes sense.
If we deicde to change this we should only read the group if there is more than one group open.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 1, 2020
@bpasero bpasero closed this as completed in 5e01fd0 Apr 1, 2020
@Tyriar Tyriar added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@bpasero @isidorn @Tyriar @chrmarti