Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access: editor picker #93637

Closed
2 tasks done
bpasero opened this issue Mar 28, 2020 · 1 comment
Closed
2 tasks done

Quick access: editor picker #93637

bpasero opened this issue Mar 28, 2020 · 1 comment

Comments

@bpasero
Copy link
Member

bpasero commented Mar 28, 2020

Refs: #69955

Complexity: 3


Quick open is now using the quick input widget that leverages our new tree widget. All quick open providers have been rewritten from scratch.

All of the existing commands for driving quick open have been preserved. Everything should work as before with some additional features as noted in the test plan.

Note: configure "workbench.quickOpen.closeOnFocusLost": false to make testing easier by keeping quick open opened even if you navigate somewhere else.

  • open a couple of editors in multiple editor groups
  • have some dirty, have some in preview
  • verify the editor picker edt shows all opened editors across all groups by appearance
  • verify the editor picker edt active shows all opened editors of the currently active group by most recently used
  • verify the editor picker edt mru shows all opened editors across all groups by most recently used
  • verify you can pick an editor to open it
  • verify you can pick an editor in the background by pressing arrow-right key or clicking with middle mouse
  • verify you can search editors by typing
  • verify you can close editors from the picker
  • verify dirty editors indicate their state on the close button
  • verify preview editors appear in italics
  • verify that you can quick-navigate through editors of the active group via Ctrl+Tab keybinding (in this mode you should not see an input field and pressing and releasing the keys should accept the active item at once)
@bpasero bpasero added this to the March 2020 milestone Mar 28, 2020
@alexdima alexdima removed their assignment Mar 31, 2020
@alexdima
Copy link
Member

Works nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants