Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access: editor picker: Editor dirty state is not announced to screen reader #93936

Closed
Tyriar opened this issue Mar 31, 2020 · 2 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93637

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362


This state:

image

Announced: "Picker quick access dot ts editor group picker 3 of 5"

This state:

image

Announced "Toolbar, close editor action"

@Tyriar
Copy link
Member Author

Tyriar commented Mar 31, 2020

When focusing the button on the recent workspace feature it announces dirty, however it should do this when you're navigating the list, not when just navigating between items. Otherwise the only way to tell if it has backups/changes is to tab into close the editor.

image

@bpasero bpasero added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues quick-pick Quick-pick widget issues labels Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 1, 2020
@bpasero bpasero closed this as completed in 5865d9c Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Needs verification in:

  • editor picker (edt)
  • files picker (e.g. having a dirty editor in history)
  • window switcher (Window > Switch Window) when having dirty files in that window
  • recently opened (when having dirty files in workspace)

@Tyriar Tyriar added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants