Tweak Welcome page's Start section #105823
Conversation
| @@ -21,7 +21,8 @@ export default () => ` | |||
| <li><a href="command:workbench.action.files.newUntitledFile">${escape(localize('welcomePage.newFile', "New file"))}</a></li> | |||
| <li class="mac-only"><a href="command:workbench.action.files.openFileFolder">${escape(localize('welcomePage.openFolder', "Open folder..."))}</a></li> | |||
| <li class="windows-only linux-only"><a href="command:workbench.action.files.openFolder">${escape(localize('welcomePage.openFolder', "Open folder..."))}</a></li> | |||
| <li><a href="command:workbench.action.addRootFolder">${escape(localize('welcomePage.addWorkspaceFolder', "Add workspace folder..."))}</a></li> | |||
| <li><a href="command:workbench.action.openWorkspace">${escape(localize('welcomePage.openWorkspace', "Open workspace..."))}</a></li> | |||
There was a problem hiding this comment.
I'm not sure we'd want to add this option as it would make the length longer. Plus, when you choose "Open Folder" you can already choose to open a workspace.
There was a problem hiding this comment.
When I use "Open folder..." on Windows I get the native "Open Folder" dialog, which means there's no way I can choose a .code-workspace file.
Can we allay your concern about making the length longer by reducing my a corresponding amount the large amount of empty space above the "Recent" header?
|
@chrmarti @misolori anything I can do to help get this merged? |
|
We are currently revisiting our Welcome page(#106715) so I don't think we'll be merging this in soon. Also, I haven't seen a request from other users so I'd be worried we'd be adding this for a small percentage. |
It got two upvotes at #63152 (comment) I'm glad to hear that Welcome page revisit is getting some love again. I do hope that will bring "Open workspace..." into it. I think it will help people see that workspaces and folders are two slightly different entities. remember that non-macOS users can't use "Open folder..." as a means to open a workspace. Might you consider allowing the "Open folder..." line become a composite on non-macOS platforms, with two hyperlinks, i.e. "Open folder or workspace..." ? That would avoid stealing another line from the page. |
I think we can do this for Windows + Linux |
|
Here it is:
|
|
I'll run this by the team to see what they think, we're currently in endgame so it might be a while before we return to this discussion. |
|
Looks good to me, though we're likely to overhaul the whole page at some point in the |
|
Closing in favor of #110333 where we discuss using a similar approach. Thanks. |
|
Sad that you didn't adopt the extra link to 'open workspace". Remember that for Windows users the "Open folder" dialog doesn't permit a code-workspace file to be opened, because it only offers folders. Might be the same on Linux. |
|
I'm still convinced that keeping the number of links low is the better experience. Also: Multi-root workspaces might be an advanced feature and the Welcome page is geared towards new users. |
|
@chrmarti at least you are being consistent with this view by having removed the (badly named) "Add workspace folder..." But personally I use the Welcome page by default (handy recently used lists are one reason) and find it a source of minor friction that if I want to open a code-workspace that is going to need browsing for I have to resort to the File menu. |
This PR addresses #63152 (comment), making the text of an entry on the Start section of the Welcome page consistent with the equivalent command on the File menu, and also adding an extra entry.
cc @misolori