-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Read Only mode #106323
Add Read Only mode #106323
Conversation
Thanks but I think this requires a different approach and I would not think that we would accept a PR to resolve this unless we can lay out exactly how this feature should work. |
@bpasero - Come on. This have been a request of the community for a very, very, very, very long time. Please be a bit more cooperative. What kind of "different approach"/(gauntlet) do you require for this to go through? |
@henrik-jensen well to begin with, this PR seems to turn the current active text editor readonly and as such if you open keybindings or settings in the editor, you cannot make changes either. I think if we want to add a feature like this, shouldn't it reset if a different file is opened? |
@bpasero Thank you, that's the kind of response I was hoping for. |
Sure, I am happy to give all the answers once we decided that we want to tackle that issue near term. But since that issue does not have our "help wanted" flag, please understand that I am currently not having the time to explain a general solution. Rather I feel that this issue should be looked at by a developer from us and not by outside contribution. |
Ok, that's fair enough. (But as a representative of the WNROMP (We Need Read Only Mode Party) I can assure you that haven't heard the last from us :-) ) |
👍 |
This PR fixes #4873
I attempted to follow the feedback outlined on the previous PR for this feature request: #82748. If I missed something, please let me know and I'd be happy to change it.