Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Read Only mode #106323

Closed
wants to merge 2 commits into from
Closed

Add Read Only mode #106323

wants to merge 2 commits into from

Conversation

jmannanc
Copy link
Contributor

@jmannanc jmannanc commented Sep 9, 2020

This PR fixes #4873

SXETcQ7wgj

I attempted to follow the feedback outlined on the previous PR for this feature request: #82748. If I missed something, please let me know and I'd be happy to change it.

@bpasero bpasero marked this pull request as draft September 10, 2020 06:02
@bpasero bpasero added this to the Backlog milestone Sep 10, 2020
@bpasero
Copy link
Member

bpasero commented Oct 3, 2020

Thanks but I think this requires a different approach and I would not think that we would accept a PR to resolve this unless we can lay out exactly how this feature should work.

@bpasero bpasero closed this Oct 3, 2020
@henrik-jensen
Copy link

@bpasero - Come on. This have been a request of the community for a very, very, very, very long time. Please be a bit more cooperative. What kind of "different approach"/(gauntlet) do you require for this to go through?

@bpasero
Copy link
Member

bpasero commented Oct 8, 2020

@henrik-jensen well to begin with, this PR seems to turn the current active text editor readonly and as such if you open keybindings or settings in the editor, you cannot make changes either. I think if we want to add a feature like this, shouldn't it reset if a different file is opened?

@henrik-jensen
Copy link

@bpasero Thank you, that's the kind of response I was hoping for.
So is this a inherent design flaw of the original monaco editor (You are the expert on original Monaco)?
If so, do you have some ideas how we can mitigate this stupid design flaw? (Global solution to a local problem does not seem to work, (no surprise)).
(In other words) What can be done?

@bpasero
Copy link
Member

bpasero commented Oct 8, 2020

Sure, I am happy to give all the answers once we decided that we want to tackle that issue near term. But since that issue does not have our "help wanted" flag, please understand that I am currently not having the time to explain a general solution. Rather I feel that this issue should be looked at by a developer from us and not by outside contribution.

@henrik-jensen
Copy link

Ok, that's fair enough. (But as a representative of the WNROMP (We Need Read Only Mode Party) I can assure you that haven't heard the last from us :-) )

@bpasero
Copy link
Member

bpasero commented Oct 8, 2020

👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add read-only mode
4 participants