Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repeated arrow-right expansion of unresolved folders when filtering a tree (#177444) #180055

Closed
wants to merge 3 commits into from
Closed

Allow repeated arrow-right expansion of unresolved folders when filtering a tree (#177444) #180055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4360b95
Allow repeated arrow-right expansion of unresolved folders when filte…
gjsjohnmurray Apr 15, 2023
89ef38d
Merge branch 'main' into fix-177444
gjsjohnmurray Apr 19, 2023
ec65673
Merge branch 'main' into fix-177444
gjsjohnmurray Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/vs/workbench/browser/actions/listCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,13 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({
}
}
}
else if (focus && !widget.getNode(focus).visible) {
// https://github.com/microsoft/vscode/issues/177444
// When filtering hides a just-resolved folder that was expanded by keyboard arrow-right we need to fix the focus
// so that the next arrow-right correctly expands (and potentially resolves) the next folder.
widget.focusPrevious();
widget.focusNext();
}
});
}
}
Expand Down