Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable breakpoint hint when a test loading icon is present #180884

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

joyceerhl
Copy link
Collaborator

Fixes #180880

export const spinningLoading = ThemeIcon.modify(Codicon.loading, 'spin');
The loading codicon is used for one of the testing states:
[TestResultState.Running, spinningLoading],
I haven't seen this with the VS Code selfhost test provider but it appears to show up for Pytest.

@joyceerhl joyceerhl enabled auto-merge (squash) April 25, 2023 21:48
@joyceerhl joyceerhl self-assigned this Apr 25, 2023
@joyceerhl joyceerhl requested a review from connor4312 April 25, 2023 21:48
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 25, 2023
@joyceerhl joyceerhl merged commit 39296d2 into main Apr 25, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/frequent-elk branch April 25, 2023 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on test decoration quickly toggles breakpoint
3 participants