Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back hack to refresh terminal scroll bar #181359

Merged
merged 2 commits into from
May 3, 2023
Merged

Bring back hack to refresh terminal scroll bar #181359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6c127
Bring back hack to refresh terminal scroll bar
Tyriar May 2, 2023
c4e0149
Move workaround into TerminalInstance.setVisible
Tyriar May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,13 +1326,13 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
// using the most up to date dimensions (eg. when terminal is created in the background
// using cached dimensions of a split terminal).
this._resize();
// Trigger a forced refresh of the viewport to sync the viewport and scroll bar. This is
// necessary if the number of rows in the terminal has decreased while it was in the
// background since scrollTop changes take no effect but the terminal's position does
// change since the number of visible rows decreases.
// HACK: Trigger a forced refresh of the viewport to sync the viewport and scroll bar.
// This is necessary if the number of rows in the terminal has decreased while it was in
// the background since scrollTop changes take no effect but the terminal's position
// does change since the number of visible rows decreases.
// This can likely be removed after https://github.com/xtermjs/xterm.js/issues/291 is
// fixed upstream.
this.xterm.forceRefresh();
setTimeout(() => this.xterm!.forceRefresh(), 0);
}
}

Expand Down