-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mangle exported symbols #182935
Mangle exported symbols #182935
Conversation
For #180461 This prototype tries to mangle exported functions, saving a further 440kb from the bundle size
This increases savings up to 3325
This should speed up compile
Maybe needs the checker to be enabled too? Just check parent chain instead for now
Finally got a successful full build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=215714 Main issue was that I was accidentally mangling ambient type declarations, which messed up some referenced libraries in remote scenarios (this was tricky to track down because it only happens in full builds, not in OSS) Local testing all seems ok although I haven't run though every scenario. Will continue testing and hopefully get this merged in June |
Use entrypoints instead
@mjbvz Can you share numbers how much slower the (product) build will be because of this? |
@jrieken This makes the This slow down is due to the large number of |
fyi @alexdima - you were wondering about the additional costs of this |
Porting #180462 to a branch in our main repo
For #180461. This prototype tries to mangle exported functions, constants, and classes
Current total savings: 1910kb
New total savings: 4077kb