Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eng - add checksum validation support to nodejs and extensions #184877

Merged
merged 29 commits into from
Jun 14, 2023
Merged

eng - add checksum validation support to nodejs and extensions #184877

merged 29 commits into from
Jun 14, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 12, 2023 •
edited
Loading

For #184885

@bpasero bpasero mentioned this pull request Jun 12, 2023
Closed
3 tasks
bpasero
bpasero commented Jun 12, 2023
View reviewed changes
product.json Show resolved Hide resolved
@bpasero bpasero marked this pull request as ready for review June 13, 2023 05:26
@bpasero bpasero added this to the June 2023 milestone Jun 13, 2023
@bpasero bpasero changed the title eng - add checksum validation support to remote eng - add checksum validation support to nodejs and extensions Jun 13, 2023
deepak1556
deepak1556 reviewed Jun 13, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
jrieken
jrieken previously approved these changes Jun 13, 2023
View reviewed changes
connor4312
connor4312 previously approved these changes Jun 13, 2023
View reviewed changes
deepak1556
deepak1556 reviewed Jun 13, 2023
View reviewed changes
build/gulpfile.reh.js Outdated Show resolved Hide resolved
@bpasero bpasero marked this pull request as draft June 13, 2023 16:32
@bpasero bpasero marked this pull request as ready for review June 14, 2023 14:12
deepak1556
deepak1556 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a production build triggered with the latest changes ? Would be good to sanity test CI before merging.

@bpasero bpasero merged commit 8afb685 into main Jun 14, 2023
@bpasero bpasero deleted the ben/remote-checksums branch June 14, 2023 14:57
@bpasero
Copy link
Member Author

bpasero commented Jun 14, 2023

https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=218631&view=results

@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@connor4312 connor4312 connor4312 left review comments

@jrieken jrieken jrieken left review comments

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@bpasero @deepak1556 @jrieken @connor4312