Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook toolbar rewrite. Adopt WorkbenchToolbar #185168

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Conversation

Yoyokrazy
Copy link
Contributor

@Yoyokrazy Yoyokrazy commented Jun 14, 2023

re: #161119

Adopting WorkbenchToolbar into notebooks. Required a rewrite of the complete toolbar, meaning strategies had to be reworked as well.

Features it brings:

  • right click to hide items
  • right click to reset toolbar to original state (all possible displayed, ignoring hidden secondary actions)

Todo:

  • adapt dynamic and label-less strategies to work alongside workbench toolbar.
  • "default" renderlabel setting ("notebook.globalToolbarShowLabel": "always") gives workbench functionality, other two labels never + dynamic use older toolbar.
    • this requires reload upon changing label setting

To enable:

  • "notebook.experimental.workbenchToolbar": true

@Yoyokrazy Yoyokrazy requested a review from rebornix June 14, 2023 23:11
@vscodenpa vscodenpa added this to the June 2023 milestone Jun 14, 2023
@rebornix rebornix enabled auto-merge (squash) June 16, 2023 00:00
@rebornix rebornix merged commit 1eec409 into main Jun 16, 2023
@rebornix rebornix deleted the milively/nb-toolbar branch June 16, 2023 00:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants