Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure tasks have been resolved before run task commands are executed, only show default build tasks in quick-pick #186025

Merged
merged 9 commits into from
Jun 23, 2023
Merged

ensure tasks have been resolved before run task commands are executed, only show default build tasks in quick-pick #186025

merged 9 commits into from
Jun 23, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 23, 2023 •
edited
Loading

fix #173384
fix #179684

see lengthy investigation / explanation starting with #173384 (comment)

@meganrogge meganrogge requested a review from Tyriar June 23, 2023 19:50
@meganrogge meganrogge self-assigned this Jun 23, 2023
@meganrogge meganrogge added this to the June 2023 milestone Jun 23, 2023
@meganrogge meganrogge changed the title fix build task issue partially fix build task issue Jun 23, 2023
@meganrogge meganrogge changed the title partially fix build task issue fix build task issue Jun 23, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2023

A more detailed PR title would be helpful as we might need to reference this later

@meganrogge meganrogge changed the title fix build task issue ensure tasks have been resolved before build task is determined, only show default build tasks in quick-pick Jun 23, 2023
@meganrogge meganrogge requested a review from Tyriar June 23, 2023 21:09
@meganrogge meganrogge enabled auto-merge June 23, 2023 21:16
@meganrogge meganrogge changed the title ensure tasks have been resolved before build task is determined, only show default build tasks in quick-pick ensure tasks have been resolved before run task commands are executed, only show default build tasks in quick-pick Jun 23, 2023
@meganrogge meganrogge merged commit 6928a28 into main Jun 23, 2023
@meganrogge meganrogge deleted the merogge/task-timing branch June 23, 2023 21:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

VS Code won`t show tasks defined in the .code-workspace file Build task not found sometimes
2 participants
@meganrogge @Tyriar