notebook symbols #191231
Merged
notebook symbols #191231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
force-pushed
the
aamunger/notebookSymbols
branch
from
a7aff0b to
2842844
Compare
rebornix
requested changes
Sep 11, 2023
src/vs/workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/viewModel/NotebookOutlineEntryFactory.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/viewModel/NotebookOutlineEntryFactory.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/viewModel/NotebookOutlineEntryFactory.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
Sep 13, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Sep 14, 2023
…ymbols notebook symbols
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for microsoft/vscode-jupyter#13930
the createOutline call is asynchronous so we can gather all code symbols from the model service at that time.
The Outline object is specific to each target, and is created and destroyed for each open/close of the goto symbols menu.
Includes some refactoring to make the changes easier to test.