Initial attempt to support editor commands #194849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a few things in a few strategic commits: ### Commit 1 The first commit contains the actual functional changes. * In our TF-IDF implementation in the Command Palette we now consume command's description if available. This will help provide more hits in the similar commands category section of the Command Palette. To do this we now include the description in the MenuItem which is needed by the Command Palette. * It allows Allows `description` to be an `ILocalizedString` so that we can include both the translated & original strings in the TF-IDF calculation
This depends on #193937 and would allow Editor Commands' descriptions to be picked up in the TF-IDF indexing of commands. The problem I currently struggle with is what to do with this introduction of `ICommandMetadata`... do we want to add it to monaco? Do we want to add maybe a subset of it (just the description property)? Additionally, I noticed that the concept of a LocalizedString isn't a thing in the monaco API... so that would be _another_ thing to introduce. Should we add these types? Or should we have `description` be a `string` and then use that instead?
TylerLeonhardt
commented
Oct 4, 2023
| @@ -53,7 +53,7 @@ class SelectToBracketAction extends EditorAction { | |||
| alias: 'Select to Bracket', | |||
| precondition: undefined, | |||
| metadata: { | |||
| description: `Select to Bracket`, | |||
| description: nls.localize2('smartSelect.selectToBracketDescription', "Select the text inside and including the brackets or curly braces"), | |||
There was a problem hiding this comment.
This is an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #193937 and would allow Editor Commands' descriptions to be picked up in the TF-IDF indexing of commands.
The problem I currently struggle with is what to do with this introduction of
ICommandMetadata... do we want to add it to monaco? Do we want to add maybe a subset of it (just the description property)?Additionally, I noticed that the concept of a LocalizedString isn't a thing in the monaco API... so that would be another thing to introduce.
Should we add these types? Or should we have
descriptionbe astringand then use that instead?