Add option to show editor actions in title bar #196609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getEditorActions returns event
bpasero
requested changes
Nov 1, 2023
bpasero
reviewed
Nov 1, 2023
bpasero
requested changes
Nov 2, 2023
bpasero
previously approved these changes
Nov 3, 2023
There was a problem hiding this comment.
@benibenj pushed 2 follow up changes, please check.
- aba22ac : change to require to pass in a
DisposableStoreso that the disposable can be added into, I think with your approach the disposable was never assigned properly because you assigned it inside the function - 1edbc50 : we now create the resource context key in the editor group view but have to be careful to use the same scoped context key service as we used to, so I instantiate it with the scoped instantiator
sandy081
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Lets get rid of TitleBarGlobalControlMenu, as they are fixed number of actions always. One less menu to manage in titleBarPart and over all
When I hide Accounts or Manage actions, they are moved to overflow menu, but they are not working in overflow menu. They are supposed to show sub menus.
|
As discussed with @sandy081, we will make Accounts/Manages Actions unhideable until we have a good solution for creating submenus for these actions when they are hidden. |
sandy081
previously approved these changes
Nov 3, 2023
alexdima
approved these changes
Nov 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new configuration option,
workbench.editor.showEditorActionsInTitleBar, which controls whether editor actions are shown in the title bar. This value only applies whenwindow.titleBarStyleis set tocustomandworkbench.editor.showTabsis set tonone. This feature is useful for users who prefer a minimalistic UI and want to access editor actions quickly.Fixes #196384