Implement a horizontal panel for the workbench #2042
Conversation
| @@ -61,28 +61,28 @@ export class ActivitybarPart extends Part implements IActivityService { | |||
| private registerListeners(): void { | |||
|
|
|||
| // Activate viewlet action on opening of a viewlet | |||
| this.toUnbind.push(this.eventService.addListener(EventType.VIEWLET_OPENING, (e: ViewletEvent) => this.onViewletOpening(e))); | |||
| this.toUnbind.push(this.eventService.addListener(EventType.VIEWLET_OPENING, (e: CompositeEvent) => this.onViewletOpening(e))); | |||
There was a problem hiding this comment.
@isidorn I think we can generalize this event to be COMPOSITE_OPENING and onCompositeOpening() because the listener seems to use the ID of the composite to do something and it also seems to be the only client through out the workbench.
There was a problem hiding this comment.
I see why this happens because opening a viewlet and panel is not yet shared in the compositePart, I will comment below about it.
| }; | ||
|
|
||
| /** | ||
| * Composites are layed out in the sidebar part of the workbench. Only one composite can be open |
There was a problem hiding this comment.
@isidorn would rephrase, it is not just sidebar
| } | ||
|
|
||
| public run(): Promise { | ||
| this.partService.setPanelHidden(false); |
There was a problem hiding this comment.
I guess this should be "true" for closing?
|
|
||
| .monaco-workbench > .part.panel > .title { | ||
| display: block; | ||
| border-top: 1px solid #007ACC |
There was a problem hiding this comment.
@isidorn is this value not dynamic depending on debug, no workspace or workspace? I would check what the statusbar does to set this color.
There was a problem hiding this comment.
@bpasero status bar does the same thing, defines a default, and then clients like debug set it to orange. I do the same here.
Implement a horizontal panel for the workbench
Adding horizontal panel to the workbench (see #1875).