Introduce text multi diff #207747
Introduce text multi diff #207747
Conversation
| for (const resource of (editor?.initialResources ?? [])) { | ||
| if (resource.original && resource.modified) { | ||
| diffEditors.push({ | ||
| kind: TabInputKind.TextDiffInput, | ||
| original: resource.original, | ||
| modified: resource.modified | ||
| }); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Note that the resources of a multi diff editor can change!
For scm, initialResources is empty, and the resources are loaded via the multi diff editor source uri.
There was a problem hiding this comment.
Hmm do you have suggestions on how to tackle this? Is there an event that fires when these resources change? I'm not sure we have other editor inputs that are like this as normally the input just becomes a new one if resources change. It could be worthwhile to not expose the resources at all then, as this would still allow closing to work properly you just wouldn't know what is inside the tab you're closing
There was a problem hiding this comment.
Yes, I'd suggest to not expose the resources for now.
And yes, there are events etc, but I guess it is a bit tricky to implement.
Fixes #206411
CC @hediet