Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up editor action command descriptions #209259

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Apr 1, 2024

Continuation of #193937 and #197442

This adds the command descriptions of editor actions to the ICommandQuickPick results so that those results can be picked up by the "similar commands" feature.

Example:

I can add:

metadata: {
    description: nls.localize2('test', "xyz"),
}

to the AddLineCommentAction... and then when I search "xyz" it'll show up.

image

Continuation of #193937 and #197442

This adds the command descriptions of editor actions to the ICommandQuickPick results so that those results can be picked up by the "similar commands" feature.

Example:

I can add:
```
metadata: {
    description: nls.localize2('test', "xyz"),
}
```
to the [AddLineCommentAction](https://github.com/microsoft/vscode/blob/7d788e70b95c79718b565ff9e255858db4cc74b3/src/vs/editor/contrib/comment/browser/comment.ts#L105)... and then when I search "xyz" it'll show up.
@TylerLeonhardt TylerLeonhardt self-assigned this Apr 1, 2024
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) April 1, 2024 14:49
@TylerLeonhardt TylerLeonhardt merged commit ade21d7 into main Apr 1, 2024
7 checks passed
@TylerLeonhardt TylerLeonhardt deleted the tyler/golden-clownfish branch April 1, 2024 15:07
@TylerLeonhardt TylerLeonhardt added this to the April 2024 milestone Apr 1, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants