add progress signal for progress service and progress indicator #210516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that this is very much a WIP 🚧 and I want some feedback on it early bc I will be OOF starting Friday.
Progress bars around the workbench/editor aren't reported to screen readers ATM despite us doing the right thing to make that happen on the
progress bar
. #209661 (comment)Therefore, this PR refactors the chat accessibility signal scheduler that we use for chat response pending into
AccessibilityProgressSignalScheduler
, which is used by theProgressService
(workbench components) andProgressIndicator
(editors).I am not sure how necessary this is as most of our progress starts and finishes pretty quickly, meaning this won't typically play with a delay of 1 second and a looping time of 3 seconds. We could of course change those, but I don't want it to be noisy. #209661 (comment)
This does not address the notebook progress signal request because that has its own custom implementation using a
progress bar
cc @amunger and @rebornix.I considered implementing this in the
progress bar
file, so this would also capture notebook progress, but that has layer issues and also is more UI than model.I would like your feedback @bpasero and @isidorn on this 🙏🏼 and whether or not you think we should have this.