deconstruct signalOptions
config object, migrate settings
#214163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #213618
We added
accessibility.signalOptions
last iteration for easier discovery/grouping of these settings because they can otherwise get lost amongst the manyaccessibility.signals
properties.However, this had side effects:
delays
property couldn't be easily adjusted in the settings UI due to the multiple nested objects. discussed this with @rzhao271 and it's a limitation of the settings UI.experimental.delays
are justified, but one cannot track data of a setting's property.This destructures that object and migrates the settings.
cc @hediet