Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only get workspace tasks when getKnownTasks is called if in a trusted workspace, prevent trust dialog from showing for this case #225087

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 7, 2024

getKnownTasks -> getGroupedTasks -> getWorkspaceTasks -> trust dialog

We only want to do this if we're in a trusted workspace, don't want to prompt in this case.

fix #224881

cc @connor4312

@meganrogge meganrogge self-assigned this Aug 7, 2024
@meganrogge meganrogge added this to the August 2024 milestone Aug 7, 2024
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@meganrogge meganrogge enabled auto-merge (squash) August 7, 2024 20:14
@meganrogge meganrogge merged commit 4a7a65c into main Aug 7, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/taskf branch August 7, 2024 20:23
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks trigger workspace trust dialog in insiders.vscode.dev repo
2 participants