Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry for duration of code actions on save #225452

Merged
merged 3 commits into from
Aug 13, 2024
Merged

telemetry for duration of code actions on save #225452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8c298
add telemetry on code actions on save
justschen Aug 12, 2024
2f65486
cleanup
justschen Aug 12, 2024
72ea274
Merge branch 'main' into justin/pidgey
justschen Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation';
import { HierarchicalKind } from 'vs/base/common/hierarchicalKind';
import { Disposable } from 'vs/base/common/lifecycle';
import { StopWatch } from 'vs/base/common/stopwatch';
import * as strings from 'vs/base/common/strings';
import { IActiveCodeEditor, isCodeEditor } from 'vs/editor/browser/editorBrowser';
import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService';
Expand All @@ -27,6 +28,7 @@ import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { IProgress, IProgressStep, Progress } from 'vs/platform/progress/common/progress';
import { Registry } from 'vs/platform/registry/common/platform';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { IWorkbenchContribution, IWorkbenchContributionsRegistry, Extensions as WorkbenchContributionsExtensions } from 'vs/workbench/common/contributions';
import { SaveReason } from 'vs/workbench/common/editor';
import { getModifiedRanges } from 'vs/workbench/contrib/format/browser/formatModified';
Expand Down Expand Up @@ -278,6 +280,7 @@ class CodeActionOnSaveParticipant extends Disposable implements ITextFileSavePar
@IHostService private readonly hostService: IHostService,
@IEditorService private readonly editorService: IEditorService,
@ICodeEditorService private readonly codeEditorService: ICodeEditorService,
@ITelemetryService private readonly telemetryService: ITelemetryService
) {
super();

Expand Down Expand Up @@ -408,7 +411,27 @@ class CodeActionOnSaveParticipant extends Disposable implements ITextFileSavePar
};

for (const codeActionKind of codeActionsOnSave) {
const sw = new StopWatch();

const actionsToRun = await this.getActionsToRun(model, codeActionKind, excludes, getActionProgress, token);

// Telemetry for duration of each code action on save.
type CodeActionOnSave = {
codeAction: string;
duration: number;
};
type CodeActionOnSaveClassification = {
owner: 'justschen';
comment: 'Information about the code action that was accepted on save.';
codeAction: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Kind of the code action setting that is run.' };
duration: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Duration it took for TS to return the action to run for each kind. ' };
};

this.telemetryService.publicLog2<CodeActionOnSave, CodeActionOnSaveClassification>('codeAction.appliedOnSave', {
codeAction: codeActionKind.value,
duration: sw.elapsed()
});

if (token.isCancellationRequested) {
actionsToRun.dispose();
return;
Expand Down
Loading