Move to new account preference concept #228897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, session preference was at a per-"set of scopes" bases. This means that an extension could ask for scopes A,B,C and get account 1... but then ask for scopes E,F and get account 2. Thinking on this more, it really doesn't make sense. An extension should have a preference wholistically since we also don't surface scopes to the user. This PR: * changes that model (while keeping the old model for migration purposes for now) * allows the user to change that value via the gear icon in the Trusted Extensions quick pick * hooks up the extension event for when the user changes that * lastly introduces a product.json entry that allows an extension to be a "child" of another extension's preference. This will be useful for GitHub Copilot & GitHub Copilot Chat sharing the same preference. Out of scope: * Adding entries to the extension editor to get to this quick pick (it'll come later, but I wanted to get these changes in now)
amunger
reviewed
Sep 18, 2024
| */ | ||
| removeAccountPreference(extensionId: string, providerId: string): void; | ||
| /** | ||
| * @deprecated Sets the session preference for the given provider and extension |
There was a problem hiding this comment.
nit: it's good to mention the alternative if there is one when deprecated
amunger
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, session preference was at a per-"set of scopes" bases. This means that an extension could ask for scopes A,B,C and get account 1... but then ask for scopes E,F and get account 2.
Thinking on this more, it really doesn't make sense. An extension should have a preference wholistically since we also don't surface scopes to the user. Additionally, if an extension wants to do something specific with another account, the
getAccountsAPI is available.This PR:
Out of scope:
ref #225943