-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylesheet partial parse #46376
Merged
Merged
Stylesheet partial parse #46376
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
787904e
First draft at partial parsing of css for emmet
ramya-rao-a 8f796cb
Partial parsing of stylesheets for Emmet
dea5096
Addressing feedback
55a4ed3
Refactoring and fixing little bug
e7dc7f8
Liitle fix
e9089d4
Equals are now equals
f0c6efa
We don't want emmet in selectors
ae81a1d
Skip comments when preparsing
7b4d979
Addressing feedback, refactoring and cleaning up code.
3536668
Update endPosition only if not eof
ramya-rao-a a7a1b17
Merge remote-tracking branch 'origin/master' into css-partial-parse
ramya-rao-a 0dddad3
Use function to find closing comment
ramya-rao-a 39fb6a8
Don't check more than 5000 characters back
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really need the whole selector, we can stop when we find a non whitespace as well