Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize definition link #54424

Merged
merged 3 commits into from
Jul 18, 2018
Merged

Finalize definition link #54424

merged 3 commits into from
Jul 18, 2018

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jul 16, 2018

  • Gives fields more explicit names to definition link fields (target and origin)
  • Moves api to vscode.d.ts
  • Makes other definition providers (such as type definition provider and implementation provider) also return definition links

@mjbvz mjbvz added this to the July 2018 milestone Jul 16, 2018
@mjbvz mjbvz self-assigned this Jul 16, 2018
@mjbvz mjbvz requested a review from jrieken July 16, 2018 22:01
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe too little documentation and maybe don't mix DefinitionLink into Definition but keep them separate and change the return types to Definition | DefinitionLink[]

mjbvz added 3 commits July 18, 2018 16:28
- Gives fields more explicit names (target and origin)
- Moves api to vscode.d.ts
- Makes other definition providers (such as type definition provider and implementation provider) also return definition links
@mjbvz mjbvz force-pushed the finalize-definition-link branch from d8ccfd7 to 9dde0ae Compare July 18, 2018 23:31
@mjbvz mjbvz merged commit 44cd521 into master Jul 18, 2018
@mjbvz mjbvz deleted the finalize-definition-link branch July 24, 2018 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants