Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Improvements for Telemetry Command #76431

Merged
merged 11 commits into from
Jul 3, 2019

Conversation

lramos15
Copy link
Member

@lramos15 lramos15 commented Jul 1, 2019

Fixes #76058 and addresses some of #76279.

The rest of #76279 will be fixed when vscode-ripgrep gets updated, but for now I at least fixed the big error which was the failure to checkout Typescript's repo.

@lramos15 lramos15 added the vscode-build VS Code build process issues label Jul 1, 2019
@lramos15 lramos15 added this to the July 2019 milestone Jul 1, 2019
@lramos15 lramos15 requested a review from joaomoreno July 1, 2019 21:25
@lramos15 lramos15 self-assigned this Jul 1, 2019
@lramos15
Copy link
Member Author

lramos15 commented Jul 2, 2019

@roblourens Has updated vscode-ripgrep. Everything seems to be working now without error.

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good!

@lramos15 lramos15 merged commit 0991720 into master Jul 3, 2019
@lramos15 lramos15 deleted the lramos15/telemetry-build-fixes branch July 9, 2019 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move extract telemetry script in pipelines to a helper script
2 participants