Fixes #69843 - Navigate File Search History

[alpalla]

This pull request implements a possible solution to issue #69843. Note that this is simply an idea for a solution, I made some assumptions that may not be true for other users. I mention these points in the "Doubts/Talking points" section of this PR.

Summary of the feature request

It was requested that when searching for a file (through Cmd+p or Ctrl+p) it should be possible to go back (and forward) through the inputed filenames (such as is possible in the Atom text editor).

Overview of the solution

I added an array to QuickOpenController to store the lastSubmittedInputValue. The value is stored each time onOK() executes.
The array always begins and ends with an empty string '' so that when the user goes beyond the very first submitted input value, the QuickOpenWidget search bar is cleared (same reasoning for when the user goes too far forward in the history).
The navigateInputHistory method I added to the QuickOpenController is the code that handles navigating the array.

How to test

To test this out, open a folder with vscode and add a custom keybinding in User/keybindings.json similar to:

[
	{
	"key": "cmd+z",
	"command": "navigateInputHistory",
	"when": "inQuickOpen",
	"args": "backwardInInputHistory"
	},
	{
	"key": "cmd+y",
	"command": "navigateInputHistory",
	"when": "inQuickOpen",
	"args": "forwardInInputHistory"
	}
]

You can then:

• search for a couple of files and hit enter to open up each of those files
• go back to searching for files with Cmd+p
• hit Cmd+z (and later Cmd+y) to ensure that the keybindings correctly go back and forth in the list of filenames you previously submitted and hit enter with.

Doubts/Talking points

1. I was not clear on the HistoryInputBox that should have been hooked up to quick open that was mention by @roblourens here, this solution is what I came up with in the meanwhile.
2. I tried using this feature in Atom and my understanding is that Atom does something more complex than simply going back through the history of submitted filenames. Is this solution too simple with respect to what Atom does?
3. What about duplicates? That is, if I enter filename "A", then hit enter, then search for "A" again and hit enter again. The way this solution is implemented, "A" would show up twice in a row in the history which is kind of ugly.
4. I could not get alt+up/down to work as a shortcut on my machine, that just kept navigating me through the list of found files.
5. Should this be a default shortcut?

[bpasero]

Thanks for the PR, but please hold on to making more changes. Given #69955 I am planning to refactor quick open quite a bit. Supporting a history of inputs is something that probably needs to go into the quick input widget: src/vs/workbench/browser/parts/quickinput/quickInput.ts

//cc @chrmarti

[bpasero]

@alpalla quick open is moving into a new world leveraging quick input facilities (see

vscode/src/vs/platform/quickinput/browser/quickAccess.ts

Line 14 in 042fded

export class QuickAccessController extends Disposable implements IQuickAccessController {

). I feel this kind of support needs to somehow go into the quick input widget itself and be there as a setting that pickers can enable (because we probably do not want this for every picker).

I suggest to coordinate this with the widget owner @chrmarti . Closing this PR.