Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language in token #93378

Merged
merged 1 commit into from
Mar 26, 2020
Merged

language in token #93378

merged 1 commit into from
Mar 26, 2020

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Mar 25, 2020

This PR fixes #86390

  • toke types defined in legends can provide the token language: e.g. function:javascript

  • if not defined, the language of the document is used

  • selectors used for styling can also use the same notation: variable.readonly:typescript

@aeschli aeschli self-assigned this Mar 25, 2020
@aeschli aeschli added this to the March 2020 milestone Mar 25, 2020
@aeschli aeschli requested a review from alexdima March 26, 2020 06:50
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like it how you use the default language id that of the current model, which means 0 API changes! ❤️

@aeschli aeschli merged commit 55646f7 into master Mar 26, 2020
@aeschli aeschli deleted the aeschli/tokenLanguage branch March 26, 2020 13:40
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[semantic tokens] Cannot customize styles based on programming language
2 participants