Put quotes around TestHost path so in case of spaces in name it start…

…s correctly (#1108) * Put quotes around TestHost path so in case of spaces in name it starts correctly * Made unit test more strict to ensure path has quotes
microsoft · Sep 19, 2017 · c5c77f4 · c5c77f4
1 parent 8746f3f
commit c5c77f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs b/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
@@ -169,7 +169,7 @@ public virtual TestProcessStartInfo GetTestHostProcessStartInfo(
                 !this.processHelper.GetCurrentProcessFileName().EndsWith(DotnetHostHelper.MONOEXENAME, StringComparison.OrdinalIgnoreCase))
             {
                 launcherPath = this.dotnetHostHelper.GetMonoPath();
-                argumentsString = testhostProcessPath + " " + argumentsString;
+                argumentsString = testhostProcessPath.AddDoubleQuote() + " " + argumentsString;
             }
 
             // For IDEs and other scenario, current directory should be the

diff --git a/.../Microsoft.TestPlatform.TestHostProvider.UnitTests/Hosting/DefaultTestHostManagerTests.cs b/.../Microsoft.TestPlatform.TestHostProvider.UnitTests/Hosting/DefaultTestHostManagerTests.cs
@@ -162,7 +162,7 @@ public void GetTestHostProcessStartInfoShouldUseMonoAsHostOnNonWindowsIfNotStart
                 default(TestRunnerConnectionInfo));
 
             Assert.AreEqual("/usr/bin/mono", info.FileName);
-            StringAssert.Contains(info.Arguments, "TestHost" + Path.DirectorySeparatorChar + "testhost.exe");
+            StringAssert.Contains(info.Arguments, "TestHost" + Path.DirectorySeparatorChar + "testhost.exe\"");
         }
 
         [TestMethod]