Do we need Microsoft.NET.Test.Sdk package to run tests?

[srivatsn]

From @alrz on August 3, 2017 20:27

This is requested by Rider, I wonder if that is not the case for VS/RS.

Copied from original issue: dotnet/roslyn#21313

[srivatsn]

From @sharwell on August 3, 2017 20:41

I'm not sure I understand the question.

The main items added by Microsoft.NET.Test.Sdk are the UnitTestContainer capability and setting the IsTestProject property. The former is supposed to be the trigger for tests, but several older test adapter implementations do not add it. Roslyn does add it, so the Microsoft.NET.Test.Sdk package should not be needed for an IDE to know which projects are test projects and which ones are not.

[srivatsn]

From @alrz on August 3, 2017 20:45

I've found this #515 I think that's the issue I'm encountering.

[srivatsn]

From @Pilchie on August 7, 2017 22:8

@ManishJayaswal or @srivatsn - do you know the right home for this?

[srivatsn]

Yes the test SDK does a few things like generate a Main method to keep the compiler happy and sets a few other things. There was an investigation about what we can do to either remove the requirement or make the Test.Sdk a real MSBuild SDK instead of a package. Moving to Microsoft/vstest

[Faizan2304]

@alrz
Microsoft.NET.Test.Sdk does lots of things. Most of the things are already covered by @srivatsn. One very important work of Microsoft.NET.Test.Sdk is that it takes the dependency of nuget package Microsoft.TestPlatform.TestHost which is needed to run the test. Without this test will not run for framework netcoreapp1.x.
We are creating Microsoft.NET.Test.Sdk this way because we want to bundle all the necessary things which are needed to run test in one place.

You can take individual nuget reference of Microsoft.TestPlatform.TestHost and run tests but it will be better if you will take nuget reference of Microsoft.NET.Test.Sdk

[alrz]

so, shouldn't we add it to Roslyn? if not how can I workaround this for now (besides referencing it from all test projects)?

[sharwell]

@alrz It's still not clear to me what the benefit would be if we add it to Roslyn. Can you describe a developer scenario which currently fails but would work if we referenced that package?

[alrz]

@sharwell

I get this in Rider. This was not shown in the past. I didn't check yet if this is required in older commits.

[sharwell]

@alrz Ah. This was caused by dotnet/roslyn#20569. The solution is dotnet/roslyn#21017, but it's blocked due to some performance concerns that need to be thoroughly tested to make sure we don't break developers working on Roslyn.

[alrz]

@sharwell

I merged dotnet/roslyn#21017 locally but the issue remains -- Rider, R# and VS "Run Tests" are unable to discover any tests. I have no idea whether this belongs to either of IDEs or some test config/dependency.

[sharwell]

@alrz After merging it, you'll need to re-run the restore script and then rebuild the entire solution. After that things should be working again.

[Faizan2304]

@alrz : Did you get your answer? Can i close this issue?

[alrz]

I no longer use IDE to run tests so this discussion is moot. Feel free to close the issue.