InProc datacollector flow changes for passing test sources #1969
Conversation
src/Microsoft.TestPlatform.Common/Interfaces/Engine/ITestCaseEventsHandler.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Common/Interfaces/Engine/ITestCaseEventsHandler.cs
Show resolved
Hide resolved
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Show resolved
Hide resolved
...Microsoft.TestPlatform.ObjectModel/DataCollector/InProcDataCollector/TestSessionStartArgs.cs
Show resolved
Hide resolved
Write separate points about the different works which are happening in this pr as there is no separate RFC for this:
|
|
Test |
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
| @@ -98,7 +104,9 @@ protected virtual IInProcDataCollector CreateDataCollector(DataCollectorSettings | |||
| /// </param> | |||
| private void TriggerTestSessionStart(object sender, SessionStartEventArgs e) | |||
| { | |||
| TestSessionStartArgs testSessionStartArgs = new TestSessionStartArgs(); | |||
| var properties = new Dictionary<string, object>(); | |||
| properties.Add(Constants.TestSourcesPropertyName, e.GetPropertyValue<IEnumerable<string>>(Constants.TestSourcesPropertyName)); | |||
There was a problem hiding this comment.
Move it to separate private method GetSessionStartProperties
src/Microsoft.TestPlatform.CrossPlatEngine/Execution/RunTestsWithSources.cs
Show resolved
Hide resolved
|
|
||
| /// TODO : Finalize Name | ||
| /// <summary> | ||
| /// Coverlet data collector assembly qualified name |
There was a problem hiding this comment.
Coverlet in proc data collector assembly qualified name.
Change in CoverletDataCollectorCodebase as well.
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/TestSourceDeterminer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/TestSourceDeterminer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/TestSourceDeterminer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/TestSourceDeterminer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/TestSourceDeterminer.cs
Outdated
Show resolved
Hide resolved
…test into InProcDCChanges
Description
1. Adding inproc data collector for coverlet in argument processor.
Adding
<InProcDataCollector friendlyName=”XPlat Code Coverage” codebase=”{codebase}” assemblyQualifiedName=”{assemblyQualifiedName}”/>in collect argument processor for CLI scenarios in case of XPlat code coverage.2. Passing test sources to inproc data collector sessionstartevent
This PR includes flow changes to pass test sources in
TestSessionStartArgs3. Using default code base to initialize inproc data collector in case code base given is relative.
Using default code base to initialize inproc data collector in case codebase given is relative.
Inproc data collector requires codebase in runsettings to work. If codebase is not present, then we skip the data collector and log an error in EqtTrace presently. We will now use a default codebase passed.