Passing runsettings as command line arguments. #297
Conversation
|
dotnet vstest.console.dll -h
|
| @@ -152,13 +152,27 @@ private int GetArgumentProcessors(string[] args, out List<IArgumentProcessor> pr | |||
| int result = 0; | |||
| var processorFactory = ArgumentProcessorFactory.Create(); | |||
|
|
|||
| foreach (string arg in args) | |||
| for (var index = 0; index < args.Length; index++) | |||
There was a problem hiding this comment.
Added a test in Acceptance Tests project.
| /// <summary> | ||
| /// The name of the command line argument that the PortArgumentExecutor handles. | ||
| /// </summary> | ||
| public const string CommandName = "--"; |
There was a problem hiding this comment.
Can you try passing --- for CLIRunSettingsArgument, I think it will work two. Because at the time of creating BuildCommandMaps( https://github.com/Microsoft/vstest/blob/master/src/vstest.console/Processors/Utilities/ArgumentProcessorFactory.cs#L226) we replace first character of CommandName with "--" because to create xplat command. All the CommandName is starting with "/", shouldn't we have something similar??
There was a problem hiding this comment.
Having "/" is good to have, but I am not sure if we need it or not.
@codito Any thought on this?
Also, as mentioned by Faizan, we are also getting "---" by default, do we need to remove it?
There was a problem hiding this comment.
/ will create confusion with root path on unix. -- looks good to me.
All the CommandName is starting with "/",
We can keep supporting it for back compact but, (IMO) we should remove this from help text for simplicity.
|
@pvlakshm Please review the documentation that will appear in console. |
|
Using msbuild /? and dotnet run /h as reference. Here is what we can have: |
Log message for logging file of test host
1) Create xlf file for all language 2) Create language resx file from xlf file 3) create satellite dll
Update diag log format for testhost. New format ensures log files are unique so that we don't run multiple testhosts with same file name in case of parallel runs.
| @@ -43,6 +43,11 @@ internal enum ArgumentProcessorPriority | |||
| RunSettings = 5, | |||
|
|
|||
| /// <summary> | |||
| /// Priority of processors related to CLI Run Settings. | |||
| /// </summary> | |||
| CLIRunSettings = 6, | |||
There was a problem hiding this comment.
So we are going to entertain commandline arg over runsetting if same arg is getting passed in through commandline and run setting, right?
|
|
||
| public void Initialize(string[] arguments) | ||
| { | ||
| // if argument is null or white space, don't do anything. |
There was a problem hiding this comment.
I think white space from comment should be removed.
| node = CreateNode(xmlDoc, key.Split('.')); | ||
| } | ||
|
|
||
| node.InnerText = WebUtility.HtmlEncode(value); |
There was a problem hiding this comment.
We should not encode value in HTML as our reader is not aware of that. We need this encoder just to pass value from dotnet test to vstest.
There was a problem hiding this comment.
@codito : all the runsettings reader are not aware that xml values could be encoded.
IMO as well, we should not encode values for now.
Any thoughts on this?
#260