-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding elements to code coverage config passed via commandline, #3162
Conversation
e.g. Input: --collect:"Code Coverage;CLRIEInstrumentationNetCore=true;CLRIEInstrumentationNetFramework=false" Output: <DataCollector friendlyName="Code Coverage" enabled="True"> <Configuration> <CLRIEInstrumentationNetCore>true</CLRIEInstrumentationNetCore> <CLRIEInstrumentationNetFramework>false</CLRIEInstrumentationNetFramework> </Configuration> </DataCollector>
Please add acceptance tests for code coverage which will cover Format setting. |
test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fhnaseer currently if you do:
dotnet test --collect "Code Coverage;XPlat Code Coverage"
we are enabling both collectors and getting 2 reports from dynamic and coverlet so we have to keep this logic.
It means that we can support arguments only using such thing:
--collect "datacollector1;arg1=val1,arg2=val2"
and for more collectors:
--collect "datacollector1;arg1=val1,arg2=val2;datacollector2;arg3=val3,arg4=val4"
you probably need to be checking if = is in the collector name and then treat as argument to previous collector. Adding acceptance tests for both scenarios would be great.
test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs
Show resolved
Hide resolved
…code-coverage build 20211111.1 Microsoft.Internal.CodeCoverage From Version 17.1.0-beta.21560.1 -> To Version 17.1.0-beta.21561.1
…d-8f377d0f6c72' into dev/fhnaseer/cc-commandline-config
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CodeCoverageTests.cs
Outdated
Show resolved
Hide resolved
Hello @fhnaseer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Adding elements to code coverage config passed via commandline,
e.g.
Input:
--collect:"Code Coverage;CLRIEInstrumentationNetCore=true;CLRIEInstrumentationNetFramework=false"
Output: