Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel discovery #3349

Merged
merged 40 commits into from
Feb 18, 2022
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
01df3aa
initial implem
Sanan07 Nov 22, 2021
3e0a4b1
temp
Sanan07 Nov 22, 2021
d114afb
initila
Sanan07 Nov 23, 2021
9bc76c7
Stopping discovery after abort
Sanan07 Nov 23, 2021
5f6ba48
removing old logic test
Sanan07 Nov 23, 2021
a239149
Fixing test
Sanan07 Nov 23, 2021
fcdd4b6
fixing last chunk logic
Sanan07 Nov 24, 2021
524448b
temp commit
Sanan07 Nov 25, 2021
e8aa241
Merge branch 'main' of https://github.com/microsoft/vstest into dev/s…
Sanan07 Nov 26, 2021
059181e
Fixing last chunk is empty case. Some refactoring
Sanan07 Nov 26, 2021
0fb8aff
writing first part of tests
Sanan07 Nov 29, 2021
a220af5
more tests
Sanan07 Dec 1, 2021
bb13111
Merge branch 'main' of https://github.com/microsoft/vstest into dev/s…
Sanan07 Dec 1, 2021
adfdabb
fixing public api
Sanan07 Dec 2, 2021
c094306
more public api
Sanan07 Dec 2, 2021
31ebaa0
changing public api files
Sanan07 Dec 3, 2021
35e7060
Merge branch 'dev/sayuzbas/par-discovery' into dev/sayuzbas/parallel-…
Sanan07 Dec 17, 2021
0a2bce3
Merge branch 'main' into pr/3226
Evangelink Feb 10, 2022
50c713e
Update src/Microsoft.TestPlatform.Common/Interfaces/Engine/ClientProt…
Evangelink Feb 10, 2022
29377a3
Apply suggestions from code review
Evangelink Feb 10, 2022
f1c872b
Fix incorrect merges + address analyzer warnings
Evangelink Feb 10, 2022
8dbbd31
Simpliy EqtTrace calls
Evangelink Feb 10, 2022
2ff5ce4
Merge branch 'main' into pr/3226
Evangelink Feb 11, 2022
e7af727
Merge branch 'main' into pr/3226
Evangelink Feb 12, 2022
36db669
Remove API duplication
Evangelink Feb 12, 2022
03eab00
Apply some code review comments
Evangelink Feb 12, 2022
fffcca5
Merge branch 'main' into pr/3226
Haplois Feb 14, 2022
46d5eef
Address some code review comments
Evangelink Feb 14, 2022
56ab677
Update src/Microsoft.TestPlatform.Client/Discovery/DiscoveryRequest.cs
Evangelink Feb 14, 2022
5271c97
Address part of the review comments
Evangelink Feb 15, 2022
226544d
Simpler API
Evangelink Feb 15, 2022
a9115b5
Merge branch 'main' into pr/3226
Evangelink Feb 15, 2022
485cf0b
Rework method
Evangelink Feb 15, 2022
547c9f2
More refactorings
Evangelink Feb 15, 2022
373510a
Fix test
Evangelink Feb 16, 2022
473360d
Remove duplications and race issues
Evangelink Feb 16, 2022
59d2563
Merge branch 'main' into pr/3226
Evangelink Feb 16, 2022
d29f007
Make public as class is internal
Evangelink Feb 16, 2022
47ff337
Fix naming
Evangelink Feb 16, 2022
1f496bd
Improves tests and remove un-needed field
Evangelink Feb 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make public as class is internal
Evangelink committed Feb 16, 2022
commit d29f00715449570df68ffd5819772717794541ad
Original file line number Diff line number Diff line change
@@ -138,14 +138,14 @@ public void AggregateDiscoveryDataMetrics(IDictionary<string, object> metrics)
/// Aggregate the source as fully discovered
/// </summary>
/// <param name="sorce">Fully discovered source</param>
internal void MarkSourcesWithStatus(ICollection<string> sources, DiscoveryStatus status)
public void MarkSourcesWithStatus(ICollection<string> sources, DiscoveryStatus status)
=> DiscoveryManager.MarkSourcesWithStatus(sources, status, _sourcesWithDiscoveryStatus);

/// <summary>
/// Aggregates the value indicating if we already sent message to IDE.
/// </summary>
/// <param name="isMessageSent">Boolean value if we already sent message to IDE</param>
internal void AggregateIsMessageSent(bool isMessageSent)
public void AggregateIsMessageSent(bool isMessageSent)
{
IsMessageSent = IsMessageSent || isMessageSent;
}
@@ -155,6 +155,6 @@ internal void AggregateIsMessageSent(bool isMessageSent)
/// </summary>
/// <param name="status">Status to filter</param>
/// <returns></returns>
internal List<string> GetSourcesWithStatus(DiscoveryStatus status)
public List<string> GetSourcesWithStatus(DiscoveryStatus status)
=> DiscoveryManager.GetSourcesWithStatus(status, _sourcesWithDiscoveryStatus);
}