-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DOTNET_ROOT env var for .NET 6.0+ #3715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
changed the title
Fix DOTNET_ROOT env var for .NET 6.0+
[After #3716] Fix DOTNET_ROOT env var for .NET 6.0+
Jun 2, 2022
Evangelink
changed the title
[After #3716] Fix DOTNET_ROOT env var for .NET 6.0+
Fix DOTNET_ROOT env var for .NET 6.0+
Jun 6, 2022
Evangelink
force-pushed
the
dotnet_root
branch
2 times, most recently
from
June 6, 2022 15:45
39a1ce7
to
108dcc3
Compare
Evangelink
commented
Jun 6, 2022
test/Microsoft.TestPlatform.TestHostProvider.UnitTests/Hosting/DotnetTestHostManagerTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.TestHostProvider.UnitTests/Hosting/DotnetTestHostManagerTests.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Jun 8, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
Evangelink
changed the title
Fix DOTNET_ROOT env var for .NET 6.0+
[WIP] Fix DOTNET_ROOT env var for .NET 6.0+
Jun 8, 2022
Evangelink
changed the title
[WIP] Fix DOTNET_ROOT env var for .NET 6.0+
Fix DOTNET_ROOT env var for .NET 6.0+
Jun 8, 2022
Evangelink
commented
Jun 8, 2022
test/Microsoft.TestPlatform.AcceptanceTests/DotnetArchitectureTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
MarcoRossignoli
approved these changes
Jun 13, 2022
Some more info dotnet/runtime#68180 (comment) |
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Jul 7, 2022
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Jul 7, 2022
Merged
MarcoRossignoli
pushed a commit
that referenced
this pull request
Jul 7, 2022
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Jul 7, 2022
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1528950 and fixes #3586