Fix get process architecture #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Jun 8, 2022
src/Microsoft.TestPlatform.PlatformAbstractions/net451/System/ProcessHelper.cs
Show resolved
Hide resolved
MarcoRossignoli
approved these changes
Jun 8, 2022
| // A pointer to a value that is set to TRUE if the process is running under WOW64. | ||
| // If the process is running under 32-bit Windows, the value is set to FALSE. | ||
| // If the process is a 64-bit application running under 64-bit Windows, the value is also set to FALSE. | ||
| [DllImport("kernel32.dll", SetLastError = true, CallingConvention = CallingConvention.Winapi)] |
There was a problem hiding this comment.
you can add CallingConvention = CallingConvention.Winapi and the return annotation also above
| if (_currentProcess.Id == processId) | ||
| { | ||
| // If we already cached the current process architecture, no need to figure it out again. | ||
| if (_currentProcessArchitecture != null) |
There was a problem hiding this comment.
Suggested change
| if (_currentProcessArchitecture != null) | |
| if (_currentProcessArchitecture is not null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix code in GetProcessArchitecture that assumed that the process is the current process, and checked IntPtr to figure out the architecture quickly. Instead we rely on intPtr only when we know we are looking at the current process, and in other cases we use the native api.
There is also more caching and fallback added when IsWow64Process2 fails because that api is not available on the system yet.
Related issue
Related dotnet/sdk#25421
It fixes part of the issue, but it looks like the DumpMinidump is recompiled somehow in dotnet sdk, and end up being unusable.