Cleanup unused usings (truly enforce ide0005 code analysis rule) #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the suggestion from dotnet/roslyn#41640 (comment)
…Microsoft.TestPlatform.VsTestConsole.TranslationLayer.xml
stan-sz
commented
Dec 28, 2022
stan-sz
commented
Dec 28, 2022
Evangelink
reviewed
Dec 29, 2022
There was a problem hiding this comment.
Hey @stan-sz, I added a couple of comments.
For future iterations, please ensure you have discussed with us or have an approved ticket before doing changes as we want to avoid wasted time/effort on changes we could reject.
src/Microsoft.TestPlatform.CrossPlatEngine/Discovery/DiscovererEnumerator.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginManager.cs
Show resolved
Hide resolved
stan-sz
changed the title
Evangelink
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure unused
usings are caught at the build time.Description
Unused
usings are part of unused code analysis rules: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0005Applie the suggestion from dotnet/roslyn#41640 (comment) and cleaned up doc-related warnings.
Related issue
Follows up on #3299 to clean up the repo from unused
usings. With that in mind, the ide0005 rule being on-but-not-enforced: