Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cfg generation #3431

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix cfg generation #3431

merged 3 commits into from
Jan 10, 2025

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jan 10, 2025

This update fixes a collection of cfg generation bugs.

  • the deprecated feature was over/under applied
  • feature dependencies weren't being properly folded
  • nested cfg declarations were redundantly declaring required features

This fixes #3425 and builds on #3430. The process of converting dependencies into cfg features is still somewhat tortured but at least now I believe we're a lot closer to quality cfg generation and I can continue to improve the internals without having to deal with a huge diff for code generation validation.

@kennykerr kennykerr merged commit 4c832c9 into master Jan 10, 2025
75 checks passed
@kennykerr kennykerr deleted the cfg-vnext branch January 10, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not compile windows-rs when enabling UI_ViewManagement feature
1 participant