Move Temp path to the user's location #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-External
This was referenced Jun 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189 , and maybe others with strange permissions errors.
Change
Move the temp directory that is used from the package specific temp to the user's temp location. This should prevent the Mandatory Low ACL that was apparently causing #189 from being inherited. While this is more avoiding the problem than fixing it, given the relatively low rate of occurrence it might be hard to ensure that it was truly fixed by actually changing the ACLs (and would require much more time and code to write).
Additionally changes the behavior of
Runtime::GetPathToto delete non-directories when they are encountered rather than just erroring directly.Validation
Manually validated that installers are downloaded to the new location; do not have a repro of #189 to try against, but given the root cause it is unlikely that it wouldn't be fixed.
Microsoft Reviewers: Open in CodeFlow