Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emulsion #2084

Closed
wants to merge 1 commit into from
Closed

Add emulsion #2084

wants to merge 1 commit into from

Conversation

Br1ght0ne
Copy link

@Br1ght0ne Br1ght0ne commented Jun 24, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 24, 2020
@ghost ghost assigned KevinLaMS Jun 24, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

This submission has moved to manual review.

latere-a-latere
latere-a-latere reviewed Jun 24, 2020
View reviewed changes
manifests/ArturKovacs/emulsion/4.0.yaml
Comment on lines +1 to +8
Id: ArturKovacs.emulsion
Version: 4.0
Name: emulsion
Publisher: ArturKovacs
License: MIT
LicenseUrl: https://raw.githubusercontent.com/ArturKovacs/emulsion/master/LICENSE.txt
AppMoniker: emulsion
Tags: image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Id: ArturKovacs.emulsion
Version: 4.0
Name: emulsion
Publisher: ArturKovacs
License: MIT
LicenseUrl: https://raw.githubusercontent.com/ArturKovacs/emulsion/master/LICENSE.txt
AppMoniker: emulsion
Tags: image
Id: ArturKovacs.Emulsion
Version: 4.0
Name: EMULSION
Publisher: ArturKovacs
License: MIT
LicenseUrl: https://raw.githubusercontent.com/ArturKovacs/emulsion/master/LICENSE.txt
AppMoniker: emulsion
Tags: image, viewer

Caps and an extra tag. I put the name in full caps because that's how the website stylizes it.

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying [email protected] for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 25, 2020
@KevinLaMS KevinLaMS added Validation-VCRuntime-Dependency and removed Needs SmartScreen Investigation Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Jun 28, 2020
@ghost
Copy link

ghost commented Jun 28, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. labels Jun 28, 2020
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Jul 13, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latere-a-latere latere-a-latere latere-a-latere left review comments

Assignees

@KevinLaMS KevinLaMS

Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Br1ght0ne @wingetbot @latere-a-latere @KevinLaMS