Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProcessHacker 2.39 #373

Closed
wants to merge 12 commits into from
Closed

Add ProcessHacker 2.39 #373

wants to merge 12 commits into from

Conversation

dmex
Copy link
Contributor

@dmex dmex commented May 20, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 373 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

dmex The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

dmex The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label May 22, 2020
@dmex
Copy link
Contributor Author

dmex commented May 22, 2020

@KevinLaMS @denelon

The submission failed with Internal-Error which isn't documented. Do we need to change the PR?

@dmex dmex mentioned this pull request Jun 2, 2020
@denelon
Copy link
Contributor

denelon commented Jun 3, 2020

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@denelon denelon linked an issue Jun 3, 2020 that may be closed by this pull request
@gandbg gandbg mentioned this pull request Aug 10, 2021
5 tasks
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 13, 2021
@ghost
Copy link

ghost commented Aug 13, 2021

Hello @dmex,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@dmex
Copy link
Contributor Author

dmex commented Aug 20, 2021

This issue was previously labeled Blocking by @denelon due to AV failures:
#373 (comment)

There was supposed to be some clarification about why Microsoft software with AV failures is allowed but third party software competing against those same Microsoft products also with AV failures isn't allowed.

There are at least 30 other submissions tagged to this thread from others who tried submitting our app but unaware of those policies and it's going to be an ongoing issue for years:

image

This area and issue needs some clarification to improve the submission experience and to resolve this 'gray area' with applications that are not malicious being blocked from winget because some bot scripts deciding they're malicious and then not being given adequate responses as to how these issues are handled or why they're blocked.

The other problem here is that applications can be submitted while clean, then months later be considered malicious but are not removed from winget and the policies/procedures for re-checking submissions and getting existing submissions removed are non-existent.

It's also been 15 months since this submission started and these problems haven't been addressed.

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Aug 20, 2021
@mi-hol
Copy link

mi-hol commented Aug 20, 2021

This area and issue needs some clarification to improve the submission experience and to resolve this 'gray area' with applications that are not malicious being blocked from winget because some bot scripts deciding they're malicious and then not being given adequate responses as to how these issues are handled or why they're blocked.

The other problem here is that applications can be submitted while clean, then months later be considered malicious but are not removed from winget and the policies/procedures for re-checking submissions and getting existing submissions removed are non-existent.

It's also been 15 months since this submission started and these problems haven't been addressed.

I fully are with this comment, probably some bad coverage in a news article is needed to get MSFT's attention

@vedantmgoyal9
Copy link
Contributor

@KevinLaMS @denelon This PR can also be closed as it uses the old manifest schema i.e. 0.1.0

@denelon denelon added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs: Attention labels Sep 10, 2021
@Masamune3210
Copy link
Contributor

metadata can easily be updated to fit the new schema, as soon as the issue with smartscreen and defender is worked out

@vedantmgoyal9
Copy link
Contributor

metadata can easily be updated to fit the new schema, as soon as the issue with smartscreen and defender is worked out

You can't update metadata as you have deleted your fork. That's why I was saying to close the PR and the package will be added once the issue is fixed.

ItzLevvie

This comment was marked as outdated.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 3, 2021
@vedantmgoyal9
Copy link
Contributor

Wait... How did winget install the manifest? On my machine, it always threw the error that "the manifest does not contain installer information"?

@ghost ghost mentioned this pull request Nov 6, 2021
@ghost ghost closed this in #34173 Nov 6, 2021
@TPS
Copy link

TPS commented Nov 6, 2021

According to linked PR, this is closed stale & not implemented, & instructs to open a new PR to move forward!

ItzLevvie

This comment was marked as outdated.

@dmex
Copy link
Contributor Author

dmex commented Nov 6, 2021

@KevinLaMS @denelon

ItzLevvie2 exploited the msft-bot to close 25 unrelated tickets which is a severe security issue. Please reopen this issue as it still has outstanding issues per your own comments earlier in this thread.

Publish the application to the Microsoft Store (which Sysinternals have done)

We can't because of there's a hard-coded exclusion blocking our binaries as mentioned by @KevinLaMS and @denelon and we're still waiting for feedback from them about it here.

You shouldn't have exploited the bot to close issues like this one, they've left it open for good reason.

@vedantmgoyal9
Copy link
Contributor

vedantmgoyal9 commented Nov 6, 2021

The problem when closing a PR using a PR is that we can't re-open them until we are the collaborator/maintainer.

Not sure, but according to what I've observed till now, is that this is a feature (not an issue, I think) of GitHub. The linked PRs are closed by the bot/user who merges the PR as in this case, @msftbot[bot] merged the PR. So, I don't think the team could anything in the bot so that it won't close the PR. If say @ItzLevvie would be the maintainer/collaborator and she "merged" (not approved) the PR, then it would show "ItzLevvie closed this in #34173 X hours ago".

Otherwise, I don't see any problem with @ItzLevvie closing old PRs except that she closed draft PRs.

@denelon
Copy link
Contributor

denelon commented Nov 8, 2021

I'm not able to Reopen this PR. The "Reopen and comment" button is greyed out, and the tooltip displays "The repository that submitted this pull request has been deleted". I don't believe the action used to close this PR was done with malicious intent.

@vedantmgoyal9
Copy link
Contributor

That is what I said in #373 (comment) 😅

@MPeti1
Copy link

MPeti1 commented Jan 7, 2022

What is the current state of this PR, then? Should a new one be opened?
We understand that Github does not allow you to reopen the issue, but what is the next step in a situation like this?

@AsciiWolf
Copy link
Contributor

Any update on this?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manifest-Validation-Error Manifest validation failed Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI timeout but still running