-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProcessHacker 2.39 #373
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Commenter does not have sufficient privileges for PR 373 in repo microsoft/winget-pkgs |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
dmex The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package) |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
dmex The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package) |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
The submission failed with Internal-Error which isn't documented. Do we need to change the PR? |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @dmex, |
This issue was previously labeled Blocking by @denelon due to AV failures: There was supposed to be some clarification about why Microsoft software with AV failures is allowed but third party software competing against those same Microsoft products also with AV failures isn't allowed. There are at least 30 other submissions tagged to this thread from others who tried submitting our app but unaware of those policies and it's going to be an ongoing issue for years: This area and issue needs some clarification to improve the submission experience and to resolve this 'gray area' with applications that are not malicious being blocked from winget because some bot scripts deciding they're malicious and then not being given adequate responses as to how these issues are handled or why they're blocked. The other problem here is that applications can be submitted while clean, then months later be considered malicious but are not removed from winget and the policies/procedures for re-checking submissions and getting existing submissions removed are non-existent. It's also been 15 months since this submission started and these problems haven't been addressed. |
I fully are with this comment, probably some bad coverage in a news article is needed to get MSFT's attention |
@KevinLaMS @denelon This PR can also be closed as it uses the old manifest schema i.e. 0.1.0 |
metadata can easily be updated to fit the new schema, as soon as the issue with smartscreen and defender is worked out |
You can't update metadata as you have deleted your fork. That's why I was saying to close the PR and the package will be added once the issue is fixed. |
Wait... How did winget install the manifest? On my machine, it always threw the error that "the manifest does not contain installer information"? |
According to linked PR, this is closed stale & not implemented, & instructs to open a new PR to move forward! |
ItzLevvie2 exploited the msft-bot to close 25 unrelated tickets which is a severe security issue. Please reopen this issue as it still has outstanding issues per your own comments earlier in this thread.
We can't because of there's a hard-coded exclusion blocking our binaries as mentioned by @KevinLaMS and @denelon and we're still waiting for feedback from them about it here. You shouldn't have exploited the bot to close issues like this one, they've left it open for good reason. |
The problem when closing a PR using a PR is that we can't re-open them until we are the collaborator/maintainer. Not sure, but according to what I've observed till now, is that this is a feature (not an issue, I think) of GitHub. The linked PRs are closed by the bot/user who merges the PR as in this case, @msftbot[bot] merged the PR. So, I don't think the team could anything in the bot so that it won't close the PR. If say @ItzLevvie would be the maintainer/collaborator and she "merged" (not approved) the PR, then it would show "ItzLevvie closed this in #34173 X hours ago". Otherwise, I don't see any problem with @ItzLevvie closing old PRs except that she closed draft PRs. |
I'm not able to Reopen this PR. The "Reopen and comment" button is greyed out, and the tooltip displays "The repository that submitted this pull request has been deleted". I don't believe the action used to close this PR was done with malicious intent. |
That is what I said in #373 (comment) 😅 |
What is the current state of this PR, then? Should a new one be opened? |
Any update on this? |
Microsoft Reviewers: Open in CodeFlow