Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include optionalDependencies for pnpm-lock.yaml parsing #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phantomrose96
Copy link

@phantomrose96 phantomrose96 commented Oct 15, 2021

I'm addressing two small issues:

  1. Packages may specify "optionalDependencies". Currently the implementation for "parsePnpmLock" does not account for those. I've added optionalDependencies to the LockDependency type and pipe them through in parsePnpmLock
  2. In a rush repository, internal packages have their version field undefined in the pnpm-lock.yaml file. This is resulting in parsed lockfile entries reading as "foo@undefined". I think it's better form to not append "@undefined" and just use the name as the key. I've edited "nameAtVersion" to reflect this. However I see there's a larger work item to handle internal packages for rush repos. If it doesn't seem worth including this partial fix for handling .tgz files, I can remove it. Removing this one.

Validation:

  • built and linked locally to a project making use of "parseLockFile". Validated behaviors described above.

@ghost
Copy link

ghost commented Oct 15, 2021

CLA assistant check
All CLA requirements met.

@phantomrose96 phantomrose96 changed the title Include optionalDependencies and avoid 'name@undefined' for pnpm-lock.yaml parsing Include optionalDependencies for pnpm-lock.yaml parsing Oct 25, 2021
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're still interested in making this change, can you please merge with master and generate a change file (run yarn and then yarn change)? I can't update the PR for you in this case since it's made from your fork's master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants