Fix: Re-order tests (#2354)

microsoftgraph · Jan 30, 2023 · b999bfc · b999bfc
1 parent cd28b4a
commit b999bfc
Show file tree

Hide file tree

Showing 49 changed files with 7 additions and 26 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -123,6 +123,10 @@ jobs:
           npx playwright install
         displayName: "Install playwright"
 
+      - script: |
+          npm run test-playwright-accessibility
+        displayName: "Run accessibility tests"
+
       - script: |
           set CI=true
           npm run test-playwright
@@ -140,10 +144,6 @@ jobs:
           PLAYWRIGHT_TESTS_PASSWORD: $(PLAYWRIGHT_TESTS_PASSWORD)
         displayName: "Run playwright tests"
 
-      - script: |
-          npm run test-playwright-accessibility
-        displayName: "Run accessibility tests"
-
       - publish: $(System.DefaultWorkingDirectory)/playwright-report
         artifact: playwright-report
         condition: always()

diff --git a/playwright.config.ts b/playwright.config.ts
@@ -8,7 +8,7 @@ const config: PlaywrightTestConfig = {
   expect: {
     toMatchSnapshot: {
       threshold: 0.3,
-      maxDiffPixelRatio: 0.01
+      maxDiffPixelRatio: 0.02
     }
   },
   use: {

diff --git a/...es/header.spec.ts-snapshots/Feedback-button-should-provide-feedback-1-win32.png b/...es/header.spec.ts-snapshots/Feedback-button-should-provide-feedback-1-win32.png
diff --git a/src/tests/ui/anonymous-experiences/request.spec.ts b/src/tests/ui/anonymous-experiences/request.spec.ts
@@ -177,6 +177,7 @@ test.describe('Permissions', () => {
     await page.locator('[aria-label="Modify permissions"]').click();
     await page.evaluate(() => document.fonts.ready);
     await page.waitForTimeout(500);
+    await page.evaluate(() => document.fonts.ready);
     const permissionsText = page.locator('text=One of the following permissions is required to run the query. Sign in with an a');
     expect(permissionsText).toBeDefined();
     expect(await page.screenshot({ clip: { x: 0, y: 0, width: 1920, height: 400 } })).toMatchSnapshot();

diff --git a/...ec.ts-snapshots/Permissions-should-show-permissions-for-me-endpoint-1-win32.png b/...ec.ts-snapshots/Permissions-should-show-permissions-for-me-endpoint-1-win32.png
diff --git a/...-via-the-dropdown-menu-changes-the-version-in-the-request-URL-field-2-win32.png b/...-via-the-dropdown-menu-changes-the-version-in-the-request-URL-field-2-win32.png
diff --git a/...-via-the-dropdown-menu-changes-the-version-in-the-request-URL-field-3-win32.png b/...-via-the-dropdown-menu-changes-the-version-in-the-request-URL-field-3-win32.png
diff --git a/...s/request.spec.ts-snapshots/Run-query-should-change-version-options-4-win32.png b/...s/request.spec.ts-snapshots/Run-query-should-change-version-options-4-win32.png
diff --git a/...-experiences/request.spec.ts-snapshots/Run-query-user-can-run-query-1-win32.png b/...-experiences/request.spec.ts-snapshots/Run-query-user-can-run-query-1-win32.png
diff --git a/...-experiences/request.spec.ts-snapshots/Run-query-user-can-run-query-2-win32.png b/...-experiences/request.spec.ts-snapshots/Run-query-user-can-run-query-2-win32.png
diff --git a/src/tests/ui/anonymous-experiences/response.spec.ts b/src/tests/ui/anonymous-experiences/response.spec.ts
@@ -22,28 +22,14 @@ test.describe('Response section', () => {
     await queryInput.click();
     queryInput.fill('https://graph.microsoft.com/v1.0/me/messages');
     await queryInput.press('Tab');
-    await page.evaluate(() => document.fonts.ready);
-    expect(await page.screenshot({ clip: { x: 300, y: -200, width: 1920, height: 1080 } })).toMatchSnapshot();
     const snippetTab = page.locator('[aria-label="Code snippets"]');
     await snippetTab.click();
-    await page.waitForTimeout(200);
-    await page.evaluate(() => document.fonts.ready);
-    expect(await page.screenshot({ clip: { x: 300, y: -200, width: 1920, height: 1080 } })).toMatchSnapshot();
     const cSharpTab = page.locator('button[role="tab"]:has-text("CSharp")');
     await cSharpTab.click();
-    await page.waitForTimeout(200);
-    await page.evaluate(() => document.fonts.ready);
-    expect(await page.screenshot({ clip: { x: 300, y: -200, width: 1920, height: 1080 } })).toMatchSnapshot();
     await page.locator('button[role="tab"]:has-text("JavaScript")').click();
     await page.locator('button[name="Java"]').click();
-    await page.waitForTimeout(200);
-    await page.evaluate(() => document.fonts.ready);
-    expect(await page.screenshot({ clip: { x: 300, y: -200, width: 1920, height: 1080 } })).toMatchSnapshot();
     await page.locator('button[role="tab"]:has-text("Go")').click();
     await page.locator('button[role="tab"]:has-text("PowerShell")').click();
-    await page.waitForTimeout(200);
-    await page.evaluate(() => document.fonts.ready);
-    expect(await page.screenshot({ clip: { x: 300, y: -200, width: 1920, height: 1080 } })).toMatchSnapshot();
   });
 
   test('should show toolkit component for a valid url', async () => {

diff --git a/...ld-open-an-expanded-modal-with-response-tabs-when-Expand-is-clicked-2-win32.png b/...ld-open-an-expanded-modal-with-response-tabs-when-Expand-is-clicked-2-win32.png
diff --git a/...ts/Response-section-should-show-a-response-for-a-successful-request-1-win32.png b/...ts/Response-section-should-show-a-response-for-a-successful-request-1-win32.png
diff --git a/...ts/Response-section-should-show-an-error-message-for-an-invalid-url-1-win32.png b/...ts/Response-section-should-show-an-error-message-for-an-invalid-url-1-win32.png
diff --git a/...ts/Response-section-should-show-an-error-message-for-an-invalid-url-2-win32.png b/...ts/Response-section-should-show-an-error-message-for-an-invalid-url-2-win32.png
diff --git a/...ots/Response-section-should-show-snippets-for-the-selected-language-1-win32.png b/...ots/Response-section-should-show-snippets-for-the-selected-language-1-win32.png
diff --git a/...ots/Response-section-should-show-snippets-for-the-selected-language-2-win32.png b/...ots/Response-section-should-show-snippets-for-the-selected-language-2-win32.png
diff --git a/...ots/Response-section-should-show-snippets-for-the-selected-language-3-win32.png b/...ots/Response-section-should-show-snippets-for-the-selected-language-3-win32.png
diff --git a/...ots/Response-section-should-show-snippets-for-the-selected-language-4-win32.png b/...ots/Response-section-should-show-snippets-for-the-selected-language-4-win32.png
diff --git a/...ots/Response-section-should-show-snippets-for-the-selected-language-5-win32.png b/...ots/Response-section-should-show-snippets-for-the-selected-language-5-win32.png
diff --git a/...hots/Response-section-should-show-toolkit-component-for-a-valid-url-1-win32.png b/...hots/Response-section-should-show-toolkit-component-for-a-valid-url-1-win32.png
diff --git a/...hots/Response-section-should-show-toolkit-component-for-a-valid-url-2-win32.png b/...hots/Response-section-should-show-toolkit-component-for-a-valid-url-2-win32.png
diff --git a/src/tests/ui/anonymous-experiences/sidebar.spec.ts b/src/tests/ui/anonymous-experiences/sidebar.spec.ts
@@ -128,7 +128,7 @@ test.describe.serial('Sample Query tab', () => {
     await page.locator('[placeholder="Search sample queries"]').fill('drive');
     await page.evaluate(() => document.fonts.ready);
     expect(await page.screenshot()).toMatchSnapshot();
-    await page.locator('[aria-label="all the items in my drive"]').click();
+    await page.locator('[aria-label="list items in my drive"]').click();
     await page.evaluate(() => document.fonts.ready);
     await page.waitForTimeout(200);
     expect(await page.screenshot()).toMatchSnapshot();

diff --git a/...s/History-tab-should-show-added-history-items-to-Today-s-collection-1-win32.png b/...s/History-tab-should-show-added-history-items-to-Today-s-collection-1-win32.png
diff --git a/...s/History-tab-should-show-added-history-items-to-Today-s-collection-2-win32.png b/...s/History-tab-should-show-added-history-items-to-Today-s-collection-2-win32.png
diff --git a/...s/History-tab-should-show-added-history-items-to-Today-s-collection-3-win32.png b/...s/History-tab-should-show-added-history-items-to-Today-s-collection-3-win32.png
diff --git a/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-1-win32.png b/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-1-win32.png
diff --git a/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-2-win32.png b/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-2-win32.png
diff --git a/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-3-win32.png b/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-3-win32.png
diff --git a/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-4-win32.png b/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-4-win32.png
diff --git a/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-6-win32.png b/...ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-6-win32.png
diff --git a/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-1-win32.png b/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-1-win32.png
diff --git a/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-2-win32.png b/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-2-win32.png
diff --git a/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-3-win32.png b/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-3-win32.png
diff --git a/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-4-win32.png b/...plorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-4-win32.png
diff --git a/...es-Explorer-should-switch-between-v1-and-beta-versions-of-resources-1-win32.png b/...es-Explorer-should-switch-between-v1-and-beta-versions-of-resources-1-win32.png
diff --git a/...es-Explorer-should-switch-between-v1-and-beta-versions-of-resources-2-win32.png b/...es-Explorer-should-switch-between-v1-and-beta-versions-of-resources-2-win32.png
diff --git a/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-1-win32.png b/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-1-win32.png
diff --git a/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-2-win32.png b/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-2-win32.png
diff --git a/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-3-win32.png b/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-3-win32.png
diff --git a/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-4-win32.png b/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-4-win32.png
diff --git a/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-5-win32.png b/...spec.ts-snapshots/Sample-Query-tab-should-search-for-a-sample-query-5-win32.png
diff --git a/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-1-win32.png b/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-1-win32.png
diff --git a/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-2-win32.png b/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-2-win32.png
diff --git a/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-3-win32.png b/...napshots/Sample-Query-tab-should-select-a-sample-query-when-clicked-3-win32.png
diff --git a/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts b/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts
@@ -29,9 +29,6 @@ test.describe('Request', () => {
   test('Access token is available and is decodeable', async () => {
     await authenticatedPage.locator('[aria-label="Access token"]').click();
     await authenticatedPage.locator('[aria-label="Copy"]').click();
-    await authenticatedPage.waitForTimeout(100);
-    await authenticatedPage.evaluate(() => document.fonts.ready);
-    expect(await authenticatedPage.screenshot({ clip: { x: 300, y: 0, width: 1920, height: 200 } })).toMatchSnapshot();
     const [page5] = await Promise.all([
       authenticatedPage.waitForEvent('popup'),
       authenticatedPage.locator('[aria-label="Get token details \\(Powered by jwt\\.ms\\)"]').click()
@@ -43,9 +40,6 @@ test.describe('Request', () => {
 test.describe.serial('Profile', () => {
   test('should show profile', async () => {
     await authenticatedPage.locator('[aria-label="profile"]').click();
-    await authenticatedPage.waitForTimeout(100);
-    await authenticatedPage.evaluate(() => document.fonts.ready);
-    expect(await authenticatedPage.screenshot()).toMatchSnapshot();
     await expect(authenticatedPage.locator('button:has-text("Consent to permissions")')).toBeVisible();
   });
 

diff --git a/...riences.spec.ts-snapshots/Profile-should-open-the-permissions-panel-1-win32.png b/...riences.spec.ts-snapshots/Profile-should-open-the-permissions-panel-1-win32.png
diff --git a/...ec.ts-snapshots/Request-Access-token-is-available-and-is-decodeable-2-win32.png b/...ec.ts-snapshots/Request-Access-token-is-available-and-is-decodeable-2-win32.png
diff --git a/...nticated-experiences.spec.ts-snapshots/Run-query-user-can-run-query-1-win32.png b/...nticated-experiences.spec.ts-snapshots/Run-query-user-can-run-query-1-win32.png