Chore: append unique paths to collection (#2560)

microsoftgraph · May 4, 2023 · db86b90 · db86b90
1 parent b0dda64
commit db86b90
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/app/middleware/localStorageMiddleware.ts b/src/app/middleware/localStorageMiddleware.ts
@@ -23,7 +23,7 @@ const localStorageMiddleware = (store: any) => (next: any) => async (action: App
     case RESOURCEPATHS_ADD_SUCCESS: {
       const collections = await collectionsCache.read();
       const item = collections.find(k => k.isDefault)!;
-      item.paths = action.response;
+      item.paths = Array.from(new Set([...item.paths, ...action.response]));
       await collectionsCache.update(item.id, item);
       break;
     }

diff --git a/src/app/services/reducers/collections-reducer.ts b/src/app/services/reducers/collections-reducer.ts
@@ -18,13 +18,9 @@ export function collections(state: Collection[] = initialState, action: AppActio
     case RESOURCEPATHS_ADD_SUCCESS:
       const index = state.findIndex(k => k.isDefault);
       if (index > -1) {
-        const paths: IResourceLink[] = [...state[index].paths];
-        action.response.forEach((element: any) => {
-          const exists = !!paths.find(k => k.key === element.key);
-          if (!exists) {
-            paths.push(element);
-          }
-        });
+        const paths: IResourceLink[] = Array.from(
+          new Set([...state[index].paths, ...action.response])
+        );
         const context = [...state];
         context[index].paths = paths;
         return context;