Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Url should be trimmed before being executed #788

Closed
baywet opened this issue Jan 5, 2021 · 3 comments · Fixed by #1305
Closed

The Url should be trimmed before being executed #788

baywet opened this issue Jan 5, 2021 · 3 comments · Fixed by #1305
Assignees
@ElinorW
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. promote type:bug Something isn't working
Milestone
Nov 11- Dec 09

Comments

@baywet
Copy link
Member

baywet commented Jan 5, 2021 •
edited by azure-boards bot
Loading

Describe the bug
If a space is present in front of the URL GE will query https://%20graph.microsoft.com/v1.0/me instead of https://graph.microsoft.com/v1.0/me.

Inadvertently adding a space is common when you copy/paste things.

To Reproduce
Steps to reproduce the behavior:

  1. Open GE
  2. Add a space in front of the URL to query i.e https://graph.microsoft.com/v1.0/me (note the space in front)
  3. Run the query
  4. the request fails

Expected behavior
GE to trim spaces on the URL so the request succeeds.
AB#7480
@ghost ghost added the ToTriage label Jan 5, 2021
@ghost ghost removed the ToTriage label Jan 13, 2021
ezkemboi added a commit to ezkemboi/microsoft-graph-explorer-v4 that referenced this issue Feb 2, 2021
@ezkemboi
trim space in url before executed
147364c 
- Fixes microsoftgraph#788
This was referenced Feb 2, 2021
Closed
Closed
@adhiambovivian adhiambovivian added type:bug Something isn't working priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. and removed Bug – P2 labels Jun 29, 2021
@RabebOthmani RabebOthmani added this to the Nov 11- Dec 09 milestone Nov 16, 2021
@ElinorW
Copy link
Contributor

ElinorW commented Dec 7, 2021

Hey @baywet
when I add a space before the GE query as such ' https://graph.microsoft.com/v1.0/me', the query runs just fine. Is this what you meant?

@baywet
Copy link
Member Author

baywet commented Dec 7, 2021

See the following screencap.

2021-12-07.08-59-42.mp4

@ElinorW
Copy link
Contributor

ElinorW commented Dec 7, 2021

@baywet Ahh got it! I've noticed the experience is different when between a signed-in user and a user who isn't signed in.
Thanks for sharing this

@ElinorW ElinorW mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElinorW ElinorW

Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. promote type:bug Something isn't working
Projects
None yet
Milestone
Nov 11- Dec 09
5 participants
@RabebOthmani @baywet @adhiambovivian @ElinorW @ddyett